zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Convert ValueErrors to SpackError subclass.

Browse Source
This commit is contained in:
Todd Gamblin 2015-02-18 16:45:54 -08:00
parent 2374eb4dca
commit 02e316e772
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/spack/spack/package.py
View File

@ -941,16 +941,17 @@ def _check_extendable(self):
def _sanity_check_extension(self):
if not self.is_extension:
raise ValueError("This package is not an extension.")
raise ActivationError("This package is not an extension.")
extendee_package = self.extendee_spec.package
extendee_package._check_extendable()
if not extendee_package.installed:
raise ValueError("Can only (de)activate extensions for installed packages.")
raise ActivationError("Can only (de)activate extensions for installed packages.")
if not self.installed:
raise ValueError("Extensions must first be installed.")
raise ActivationError("Extensions must first be installed.")
if not self.extendee_spec.name in self.extendees:
raise ValueError("%s does not extend %s!" % (self.name, self.extendee.name))
raise ActivationError("%s does not extend %s!" % (self.name, self.extendee.name))
def do_activate(self, **kwargs):