Massive conversion from Package to AutotoolsPackage (#2845)

* Massive conversion from Package to AutotoolsPackage

* Forgot to convert p4est to AutotoolsPackage

* Fix typo

* Fix broken link in docs

var/spack/repos/builtin/packages/czmq/package.py

@@ -23,10 +23,9 @@
 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
 ##############################################################################
 from spack import *
-import os
 
 
-class Czmq(Package):
+class Czmq(AutotoolsPackage):
     """ A C interface to the ZMQ library """
     homepage = "http://czmq.zeromq.org"
     url      = "https://github.com/zeromq/czmq/archive/v3.0.2.tar.gz"
@@ -40,7 +39,7 @@ class Czmq(Package):
     depends_on('pkg-config', type='build')
     depends_on('zeromq')
 
-    def install(self, spec, prefix):
+    def autoreconf(self, spec, prefix):
         # Work around autogen.sh oddities
         # bash = which("bash")
         # bash("./autogen.sh")
@@ -48,14 +47,10 @@ def install(self, spec, prefix):
         autoreconf = which("autoreconf")
         autoreconf("--install", "--verbose", "--force",
                    "-I", "config",
-                   "-I", os.path.join(spec['pkg-config'].prefix,
-                                      "share", "aclocal"),
-                   "-I", os.path.join(spec['automake'].prefix,
-                                      "share", "aclocal"),
-                   "-I", os.path.join(spec['libtool'].prefix,
-                                      "share", "aclocal"),
+                   "-I", join_path(spec['pkg-config'].prefix,
+                                   "share", "aclocal"),
+                   "-I", join_path(spec['automake'].prefix,
+                                   "share", "aclocal"),
+                   "-I", join_path(spec['libtool'].prefix,
+                                   "share", "aclocal"),
                    )
-        configure("--prefix=%s" % prefix)
-
-        make()
-        make("install")