Massive conversion from Package to AutotoolsPackage (#2845)

* Massive conversion from Package to AutotoolsPackage

* Forgot to convert p4est to AutotoolsPackage

* Fix typo

* Fix broken link in docs

lib/spack/docs/packaging_guide.rst

@@ -2007,10 +2007,15 @@ The last element of a package is its ``install()`` method.  This is
 where the real work of installation happens, and it's the main part of
 the package you'll need to customize for each piece of software.
 
-.. literalinclude::  ../../../var/spack/repos/builtin/packages/mpfr/package.py
+.. code-block:: python
-   :pyobject: Mpfr.install
    :linenos:
 
+   def install(self, spec prefix):
+       configure('--prefix={0}'.format(prefix))
+
+       make()
+       make('install')
+
 ``install`` takes a ``spec``: a description of how the package should
 be built, and a ``prefix``: the path to the directory where the
 software should be installed.

var/spack/repos/builtin/packages/applewmproto/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Applewmproto(Package):
+class Applewmproto(AutotoolsPackage):
     """Apple Rootless Window Management Extension.
 
     This extension defines a protcol that allows X window managers
@@ -39,8 +39,3 @@ class Applewmproto(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make('install')

var/spack/repos/builtin/packages/appres/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Appres(Package):
+class Appres(AutotoolsPackage):
     """The appres program prints the resources seen by an application (or
     subhierarchy of an application) with the specified class and instance
     names.  It can be used to determine which resources a particular
@@ -42,9 +42,3 @@ class Appres(Package):
     depends_on('xproto@7.0.17:', type='build')
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/asciidoc/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Asciidoc(Package):
+class Asciidoc(AutotoolsPackage):
     """A presentable text document format for writing articles, UNIX man
     pages and other small to medium sized documents."""
 
@@ -38,9 +38,3 @@ class Asciidoc(Package):
     depends_on('libxslt')
     depends_on('docbook-xml')
     depends_on('docbook-xsl')
-
-    def install(self, spec, prefix):
-        configure('--prefix=%s' % prefix)
-
-        make()
-        make("install")

var/spack/repos/builtin/packages/atk/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Atk(Package):
+class Atk(AutotoolsPackage):
     """ATK provides the set of accessibility interfaces that are
        implemented by other toolkits and applications. Using the ATK
        interfaces, accessibility tools have full access to view and
@@ -43,8 +43,3 @@ def url_for_version(self, version):
         """Handle atk's version-based custom URLs."""
         url = 'http://ftp.gnome.org/pub/gnome/sources/atk'
         return url + '/%s/atk-%s.tar.xz' % (version.up_to(2), version)
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/bdftopcf/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Bdftopcf(Package):
+class Bdftopcf(AutotoolsPackage):
     """bdftopcf is a font compiler for the X server and font server.  Fonts
     in Portable Compiled Format can be read by any architecture, although
     the file is structured to allow one particular architecture to read
@@ -42,9 +42,3 @@ class Bdftopcf(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/beforelight/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Beforelight(Package):
+class Beforelight(AutotoolsPackage):
     """The beforelight program is a sample implementation of a screen saver
     for X servers supporting the MIT-SCREEN-SAVER extension.   It is only
     recommended for use as a code sample, as it does not include features
@@ -42,9 +42,3 @@ class Beforelight(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/bertini/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Bertini(Package):
+class Bertini(AutotoolsPackage):
     """Bertini is a general-purpose solver, written in C, that was created
     for research about polynomial continuation. It solves for the numerical
     solution of systems of polynomial equations using homotopy continuation."""
@@ -42,9 +42,3 @@ class Bertini(Package):
     depends_on('gmp')
     depends_on('mpfr')
     depends_on('mpi', when='+mpi')
-
-    def install(self, spec, prefix):
-        configure('--prefix=%s' % prefix)
-
-        make()
-        make("install")

var/spack/repos/builtin/packages/bigreqsproto/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Bigreqsproto(Package):
+class Bigreqsproto(AutotoolsPackage):
     """Big Requests Extension.
 
     This extension defines a protocol to enable the use of requests
@@ -38,8 +38,3 @@ class Bigreqsproto(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make('install')

var/spack/repos/builtin/packages/bison/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Bison(Package):
+class Bison(AutotoolsPackage):
     """Bison is a general-purpose parser generator that converts
     an annotated context-free grammar into a deterministic LR or
     generalized LR (GLR) parser employing LALR(1) parser tables."""
@@ -36,9 +36,3 @@ class Bison(Package):
     version('3.0.4', 'a586e11cd4aff49c3ff6d3b6a4c9ccf8')
 
     depends_on("m4", type='build')
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-
-        make()
-        make("install")

var/spack/repos/builtin/packages/bitmap/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Bitmap(Package):
+class Bitmap(AutotoolsPackage):
     """bitmap, bmtoa, atobm - X bitmap (XBM) editor and converter utilities."""
 
     homepage = "http://cgit.freedesktop.org/xorg/app/bitmap"
@@ -43,9 +43,3 @@ class Bitmap(Package):
     depends_on('xproto@7.0.25:', type='build')
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/cddlib/package.py

@@ -26,7 +26,7 @@
 from spack import *
 
 
-class Cddlib(Package):
+class Cddlib(AutotoolsPackage):
     """The C-library cddlib is a C implementation of the Double Description
     Method of Motzkin et al. for generating all vertices (i.e. extreme points)
     and extreme rays of a general convex polyhedron in R^d given by a system
@@ -51,8 +51,3 @@ def url_for_version(self, version):
 
     depends_on("gmp")
     depends_on("libtool", type="build")
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/cfitsio/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Cfitsio(Package):
+class Cfitsio(AutotoolsPackage):
     """CFITSIO is a library of C and Fortran subroutines for reading and writing
     data files in FITS (Flexible Image Transport System) data format.
     """
@@ -37,8 +37,3 @@ class Cfitsio(Package):
     def url_for_version(self, version):
         url = 'ftp://heasarc.gsfc.nasa.gov/software/fitsio/c/cfitsio{0}.tar.gz'
         return url.format(version.joined)
-
-    def install(self, spec, prefix):
-        configure('--prefix=' + prefix)
-        make()
-        make('install')

var/spack/repos/builtin/packages/cityhash/package.py

@@ -23,10 +23,9 @@
 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
 ##############################################################################
 from spack import *
-from spack.util.environment import *
 
 
-class Cityhash(Package):
+class Cityhash(AutotoolsPackage):
     """CityHash, a family of hash functions for strings."""
 
     homepage = "https://github.com/google/cityhash"
@@ -37,8 +36,5 @@ class Cityhash(Package):
     version('master', branch='master',
             git='https://github.com/google/cityhash.git')
 
-    def install(self, spec, prefix):
+    def configure_args(self):
-        configure('--enable-sse4.2', '--prefix=%s' % prefix)
+        return ['--enable-sse4.2']
-
-        make()
-        make("install")

var/spack/repos/builtin/packages/compiz/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Compiz(Package):
+class Compiz(AutotoolsPackage):
     """compiz - OpenGL window and compositing manager.
 
     Compiz is an OpenGL compositing manager that use
@@ -55,9 +55,3 @@ class Compiz(Package):
     depends_on('libpng')
     depends_on('glib')
     depends_on('gconf')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/compositeproto/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Compositeproto(Package):
+class Compositeproto(AutotoolsPackage):
     """Composite Extension.
 
     This package contains header files and documentation for the composite
@@ -38,8 +38,3 @@ class Compositeproto(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make('install')

var/spack/repos/builtin/packages/constype/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Constype(Package):
+class Constype(AutotoolsPackage):
     """constype prints on the standard output the Sun code for the type of
     display that the specified device is.
 
@@ -39,9 +39,3 @@ class Constype(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/coreutils/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Coreutils(Package):
+class Coreutils(AutotoolsPackage):
     """The GNU Core Utilities are the basic file, shell and text
        manipulation utilities of the GNU operating system.  These are
        the core utilities which are expected to exist on every
@@ -35,8 +35,3 @@ class Coreutils(Package):
     url      = "http://ftp.gnu.org/gnu/coreutils/coreutils-8.23.tar.xz"
 
     version('8.23', 'abed135279f87ad6762ce57ff6d89c41')
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/czmq/package.py

@@ -23,10 +23,9 @@
 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
 ##############################################################################
 from spack import *
-import os
 
 
-class Czmq(Package):
+class Czmq(AutotoolsPackage):
     """ A C interface to the ZMQ library """
     homepage = "http://czmq.zeromq.org"
     url      = "https://github.com/zeromq/czmq/archive/v3.0.2.tar.gz"
@@ -40,7 +39,7 @@ class Czmq(Package):
     depends_on('pkg-config', type='build')
     depends_on('zeromq')
 
-    def install(self, spec, prefix):
+    def autoreconf(self, spec, prefix):
         # Work around autogen.sh oddities
         # bash = which("bash")
         # bash("./autogen.sh")
@@ -48,14 +47,10 @@ def install(self, spec, prefix):
         autoreconf = which("autoreconf")
         autoreconf("--install", "--verbose", "--force",
                    "-I", "config",
-                   "-I", os.path.join(spec['pkg-config'].prefix,
+                   "-I", join_path(spec['pkg-config'].prefix,
                                    "share", "aclocal"),
-                   "-I", os.path.join(spec['automake'].prefix,
+                   "-I", join_path(spec['automake'].prefix,
                                    "share", "aclocal"),
-                   "-I", os.path.join(spec['libtool'].prefix,
+                   "-I", join_path(spec['libtool'].prefix,
                                    "share", "aclocal"),
                    )
-        configure("--prefix=%s" % prefix)
-
-        make()
-        make("install")

var/spack/repos/builtin/packages/damageproto/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Damageproto(Package):
+class Damageproto(AutotoolsPackage):
     """X Damage Extension.
 
     This package contains header files and documentation for the X Damage
@@ -38,8 +38,3 @@ class Damageproto(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make('install')

var/spack/repos/builtin/packages/datamash/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Datamash(Package):
+class Datamash(AutotoolsPackage):
     """GNU datamash is a command-line program which performs basic numeric,
     textual and statistical operations on input textual data files.
     """
@@ -37,8 +37,3 @@ class Datamash(Package):
     version('1.0.7', '9f317bab07454032ba9c068e7f17b04b')
     version('1.0.6', 'ff26fdef0f343cb695cf1853e14a1a5b')
     version('1.0.5', '9a29549dc7feca49fdc5fab696614e11')
-
-    def install(self, spec, prefix):
-        configure('--prefix=%s' % prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/dmxproto/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Dmxproto(Package):
+class Dmxproto(AutotoolsPackage):
     """Distributed Multihead X (DMX) Extension.
 
     This extension defines a protocol for clients to access a front-end proxy
@@ -39,8 +39,3 @@ class Dmxproto(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make('install')

var/spack/repos/builtin/packages/dri2proto/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Dri2proto(Package):
+class Dri2proto(AutotoolsPackage):
     """Direct Rendering Infrastructure 2 Extension.
 
     This extension defines a protocol to securely allow user applications to
@@ -39,8 +39,3 @@ class Dri2proto(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make('install')

var/spack/repos/builtin/packages/dri3proto/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Dri3proto(Package):
+class Dri3proto(AutotoolsPackage):
     """Direct Rendering Infrastructure 3 Extension.
 
     This extension defines a protocol to securely allow user applications to
@@ -39,8 +39,3 @@ class Dri3proto(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make('install')

var/spack/repos/builtin/packages/editres/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Editres(Package):
+class Editres(AutotoolsPackage):
     """Dynamic resource editor for X Toolkit applications."""
 
     homepage = "http://cgit.freedesktop.org/xorg/app/editres"
@@ -40,9 +40,3 @@ class Editres(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/elfutils/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Elfutils(Package):
+class Elfutils(AutotoolsPackage):
     """elfutils is a collection of various binary tools such as
     eu-objdump, eu-readelf, and other utilities that allow you to
     inspect and manipulate ELF files. Refer to Table 5.Tools Included
@@ -41,10 +41,9 @@ class Elfutils(Package):
 
     provides('elf')
 
-    def install(self, spec, prefix):
+    def autoreconf(self, spec, prefix):
         autoreconf = which('autoreconf')
         autoreconf('-if')
 
-        configure('--prefix=%s' % prefix, '--enable-maintainer-mode')
+    def configure_args(self):
-        make()
+        return ['--enable-maintainer-mode']
-        make("install")

var/spack/repos/builtin/packages/emacs/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Emacs(Package):
+class Emacs(AutotoolsPackage):
     """The Emacs programmable text editor."""
 
     homepage = "https://www.gnu.org/software/emacs"
@@ -47,7 +47,7 @@ class Emacs(Package):
     depends_on('libxaw', when='+X toolkit=athena')
     depends_on('gtkplus+X', when='+X toolkit=gtk')
 
-    def install(self, spec, prefix):
+    def configure_args(self):
         args = []
         toolkit = spec.variants['toolkit'].value
         if '+X' in spec:
@@ -61,7 +61,4 @@ def install(self, spec, prefix):
         else:
             args = ['--without-x']
 
-        configure('--prefix={0}'.format(prefix), *args)
+        return args
-
-        make()
-        make("install")

var/spack/repos/builtin/packages/evieext/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Evieext(Package):
+class Evieext(AutotoolsPackage):
     """Extended Visual Information Extension (XEVIE).
 
     This extension defines a protocol for a client to determine information
@@ -38,8 +38,3 @@ class Evieext(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make('install')

var/spack/repos/builtin/packages/exuberant-ctags/package.py

@@ -25,15 +25,9 @@
 from spack import *
 
 
-class ExuberantCtags(Package):
+class ExuberantCtags(AutotoolsPackage):
     """The canonical ctags generator"""
     homepage = "ctags.sourceforge.net"
     url      = "http://downloads.sourceforge.net/project/ctags/ctags/5.8/ctags-5.8.tar.gz"
 
     version('5.8', 'c00f82ecdcc357434731913e5b48630d')
-
-    def install(self, spec, prefix):
-        configure('--prefix=%s' % prefix)
-
-        make()
-        make("install")

var/spack/repos/builtin/packages/fastx-toolkit/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class FastxToolkit(Package):
+class FastxToolkit(AutotoolsPackage):
     """The FASTX-Toolkit is a collection of command line tools for
        Short-Reads FASTA/FASTQ files preprocessing."""
 
@@ -35,9 +35,3 @@ class FastxToolkit(Package):
     version('0.0.14', 'bf1993c898626bb147de3d6695c20b40')
 
     depends_on('libgtextutils')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/fish/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Fish(Package):
+class Fish(AutotoolsPackage):
     """fish is a smart and user-friendly command line shell for OS X, Linux, and
     the rest of the family.
     """
@@ -35,9 +35,3 @@ class Fish(Package):
     list_url = "http://fishshell.com/"
 
     version('2.2.0', 'a76339fd14ce2ec229283c53e805faac48c3e99d9e3ede9d82c0554acfc7b77a')
-
-    def install(self, spec, prefix):
-        configure('--prefix=%s' % prefix)
-
-        make()
-        make("install")

var/spack/repos/builtin/packages/fixesproto/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Fixesproto(Package):
+class Fixesproto(AutotoolsPackage):
     """X Fixes Extension.
 
     The extension makes changes to many areas of the protocol to resolve
@@ -39,8 +39,3 @@ class Fixesproto(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make('install')

var/spack/repos/builtin/packages/font-util/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class FontUtil(Package):
+class FontUtil(AutotoolsPackage):
     """X.Org font package creation/installation utilities."""
 
     homepage = "http://cgit.freedesktop.org/xorg/font/util"
@@ -35,9 +35,3 @@ class FontUtil(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/fontcacheproto/package.py

@@ -25,15 +25,10 @@
 from spack import *
 
 
-class Fontcacheproto(Package):
+class Fontcacheproto(AutotoolsPackage):
     """X.org FontcacheProto protocol headers."""
 
     homepage = "http://cgit.freedesktop.org/xorg/proto/fontcacheproto"
     url      = "https://www.x.org/archive/individual/proto/fontcacheproto-0.1.3.tar.gz"
 
     version('0.1.3', '5a91ab914ffbfbc856e6fcde52e6f3e3')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make('install')

var/spack/repos/builtin/packages/fontsproto/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Fontsproto(Package):
+class Fontsproto(AutotoolsPackage):
     """X Fonts Extension."""
 
     homepage = "http://cgit.freedesktop.org/xorg/proto/fontsproto"
@@ -35,8 +35,3 @@ class Fontsproto(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make('install')

var/spack/repos/builtin/packages/fonttosfnt/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Fonttosfnt(Package):
+class Fonttosfnt(AutotoolsPackage):
     """Wrap a bitmap font in a sfnt (TrueType) wrapper."""
 
     homepage = "http://cgit.freedesktop.org/xorg/app/fonttosfnt"
@@ -39,9 +39,3 @@ class Fonttosfnt(Package):
     depends_on('xproto', type='build')
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/fslsfonts/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Fslsfonts(Package):
+class Fslsfonts(AutotoolsPackage):
     """fslsfonts produces a list of fonts served by an X font server."""
 
     homepage = "http://cgit.freedesktop.org/xorg/app/fslsfonts"
@@ -38,9 +38,3 @@ class Fslsfonts(Package):
     depends_on('xproto@7.0.25:', type='build')
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/fstobdf/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Fstobdf(Package):
+class Fstobdf(AutotoolsPackage):
     """The fstobdf program reads a font from a font server and prints a BDF
     file on the standard output that may be used to recreate the font.
     This is useful in testing servers, debugging font metrics, and
@@ -42,9 +42,3 @@ class Fstobdf(Package):
     depends_on('xproto@7.0.25:', type='build')
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/gccmakedep/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Gccmakedep(Package):
+class Gccmakedep(AutotoolsPackage):
     """X.org gccmakedep utilities."""
 
     homepage = "https://cgit.freedesktop.org/xorg/util/gccmakedep/"
@@ -34,9 +34,3 @@ class Gccmakedep(Package):
     version('1.0.3', '127ddb6131eb4a56fdf6644a63ade788')
 
     depends_on('pkg-config@0.9.0:', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/gconf/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Gconf(Package):
+class Gconf(AutotoolsPackage):
     """GConf is a system for storing application preferences."""
 
     homepage = "https://projects.gnome.org/gconf/"
@@ -43,9 +43,3 @@ class Gconf(Package):
     # gobject-2.0 >= 2.7.0
     # dbus-1 >= 1.0.0
     # dbus-glib-1 >= 0.74
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/gdk-pixbuf/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class GdkPixbuf(Package):
+class GdkPixbuf(AutotoolsPackage):
     """The Gdk Pixbuf is a toolkit for image loading and pixel buffer
        manipulation. It is used by GTK+ 2 and GTK+ 3 to load and
        manipulate images. In the past it was distributed as part of
@@ -42,8 +42,3 @@ class GdkPixbuf(Package):
     depends_on("jpeg")
     depends_on("libpng")
     depends_on("libtiff")
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/giflib/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Giflib(Package):
+class Giflib(AutotoolsPackage):
     """The GIFLIB project maintains the giflib service library, which has
     been pulling images out of GIFs since 1989."""
 
@@ -33,9 +33,3 @@ class Giflib(Package):
     url      = "https://downloads.sourceforge.net/project/giflib/giflib-5.1.4.tar.bz2"
 
     version('5.1.4', '2c171ced93c0e83bb09e6ccad8e3ba2b')
-
-    def install(self, spec, prefix):
-        configure('--prefix=%s' % prefix)
-
-        make()
-        make("install")

var/spack/repos/builtin/packages/glib/package.py

@@ -23,10 +23,9 @@
 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
 ##############################################################################
 from spack import *
-import os
 
 
-class Glib(Package):
+class Glib(AutotoolsPackage):
     """The GLib package contains a low-level libraries useful for
        providing data structure handling for C, portability wrappers
        and interfaces for such runtime functionality as an event loop,
@@ -59,17 +58,17 @@ def url_for_version(self, version):
         url = 'http://ftp.gnome.org/pub/gnome/sources/glib'
         return url + '/%s/glib-%s.tar.xz' % (version.up_to(2), version)
 
-    def install(self, spec, prefix):
+    def autoreconf(self, spec, prefix):
         autoreconf = which("autoreconf")
         autoreconf("--install", "--verbose", "--force",
                    "-I", "config",
-                   "-I", os.path.join(spec['pkg-config'].prefix,
+                   "-I", join_path(spec['pkg-config'].prefix,
                                    "share", "aclocal"),
-                   "-I", os.path.join(spec['automake'].prefix,
+                   "-I", join_path(spec['automake'].prefix,
                                    "share", "aclocal"),
-                   "-I", os.path.join(spec['libtool'].prefix,
+                   "-I", join_path(spec['libtool'].prefix,
                                    "share", "aclocal"),
                    )
-        configure("--prefix=%s" % prefix)
+
-        make()
+    def install(self, spec, prefix):
         make("install", parallel=False)

var/spack/repos/builtin/packages/globus-toolkit/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class GlobusToolkit(Package):
+class GlobusToolkit(AutotoolsPackage):
     """The Globus Toolkit is an open source software toolkit used for building
        grids"""
 
@@ -33,8 +33,3 @@ class GlobusToolkit(Package):
     url      = "http://toolkit.globus.org/ftppub/gt6/installers/src/globus_toolkit-6.0.1470089956.tar.gz"
 
     version('6.0.1470089956', 'b77fe3cc5a5844df995688b0e630d077')
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-        make()
-        make('install')

var/spack/repos/builtin/packages/glog/package.py

@@ -25,15 +25,10 @@
 from spack import *
 
 
-class Glog(Package):
+class Glog(AutotoolsPackage):
     """C++ implementation of the Google logging module."""
 
     homepage = "https://github.com/google/glog"
     url      = "https://github.com/google/glog/archive/v0.3.3.tar.gz"
 
     version('0.3.3', 'c1f86af27bd9c73186730aa957607ed0')
-
-    def install(self, spec, prefix):
-        configure("--prefix=" + prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/glproto/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Glproto(Package):
+class Glproto(AutotoolsPackage):
     """OpenGL Extension to the X Window System.
 
     This extension defines a protocol for the client to send 3D rendering
@@ -38,8 +38,3 @@ class Glproto(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make('install')

var/spack/repos/builtin/packages/gnutls/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Gnutls(Package):
+class Gnutls(AutotoolsPackage):
     """GnuTLS is a secure communications library implementing the SSL,
        TLS and DTLS protocols and technologies around them. It
        provides a simple C language application programming interface
@@ -40,8 +40,3 @@ class Gnutls(Package):
     version('3.3.9', 'ff61b77e39d09f1140ab5a9cf52c58b6')
 
     depends_on("nettle")
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/gperf/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Gperf(Package):
+class Gperf(AutotoolsPackage):
     """GNU gperf is a perfect hash function generator. For a given
     list of strings, it produces a hash function and hash table, in
     form of C or C++ code, for looking up a value depending on the
@@ -38,9 +38,4 @@ class Gperf(Package):
 
     version('3.0.4', 'c1f1db32fb6598d6a93e6e88796a8632')
 
-    def install(self, spec, prefix):
+    # NOTE: `make check` is known to fail tests
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        # make('check')  # fails tests
-        make('install')

var/spack/repos/builtin/packages/gperftools/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Gperftools(Package):
+class Gperftools(AutotoolsPackage):
     """Google's fast malloc/free implementation, especially for
        multi-threaded applications.  Contains tcmalloc, heap-checker,
        heap-profiler, and cpu-profiler.
@@ -40,8 +40,3 @@ class Gperftools(Package):
             url="https://googledrive.com/host/0B6NtGsLhIcf7MWxMMF9JdTN3UVk/gperftools-2.3.tar.gz")
 
     depends_on("libunwind")
-
-    def install(self, spec, prefix):
-        configure("--prefix=" + prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/grandr/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Grandr(Package):
+class Grandr(AutotoolsPackage):
     """RandR user interface using GTK+ libraries."""
 
     homepage = "https://cgit.freedesktop.org/xorg/app/grandr"
@@ -36,10 +36,3 @@ class Grandr(Package):
     depends_on('gtkplus@2.0.0:')
     depends_on('gconf')
     depends_on('xrandr@1.2:')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('check')
-        make('install')

var/spack/repos/builtin/packages/gtkplus/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Gtkplus(Package):
+class Gtkplus(AutotoolsPackage):
     """The GTK+ 2 package contains libraries used for creating graphical user
        interfaces for applications."""
     homepage = "http://www.gtk.org"
@@ -47,8 +47,3 @@ def patch(self):
         # remove disable deprecated flag.
         filter_file(r'CFLAGS="-DGDK_PIXBUF_DISABLE_DEPRECATED $CFLAGS"',
                     '', 'configure', string=True)
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/gts/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Gts(Package):
+class Gts(AutotoolsPackage):
     """GTS stands for the GNU Triangulated Surface Library.
 
     It is an Open Source Free Software Library intended to provide a set of
@@ -46,8 +46,3 @@ class Gts(Package):
     version('121130', '023ebb6b13b8707534182a3ef0d12908')
 
     depends_on('glib')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-        make()
-        make('install')

var/spack/repos/builtin/packages/harfbuzz/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Harfbuzz(Package):
+class Harfbuzz(AutotoolsPackage):
     """The Harfbuzz package contains an OpenType text shaping engine."""
     homepage = "http://www.freedesktop.org/wiki/Software/HarfBuzz/"
     url      = "http://www.freedesktop.org/software/harfbuzz/release/harfbuzz-0.9.37.tar.bz2"
@@ -41,8 +41,3 @@ class Harfbuzz(Package):
 
     def patch(self):
         change_sed_delimiter('@', ';', 'src/Makefile.in')
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/heppdt/package.py

@@ -26,7 +26,7 @@
 from spack import *
 
 
-class Heppdt(Package):
+class Heppdt(AutotoolsPackage):
     """The HepPID library contains translation methods for particle ID's
     to and from various Monte Carlo generators and the PDG standard
     numbering scheme. We realize that the generators adhere closely
@@ -40,9 +40,3 @@ class Heppdt(Package):
     version('3.03.01', 'd411f3bfdf9c4350d802241ba2629cc2')
     version('3.03.00', 'cd84d0a0454be982dcd8c285e060a7b3')
     version('2.06.01', '5688b4bdbd84b48ed5dd2545a3dc33c0')
-
-    def install(self, spec, prefix):
-        configure('--prefix=%s' % prefix)
-
-        make()
-        make("install")

var/spack/repos/builtin/packages/hsakmt/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Hsakmt(Package):
+class Hsakmt(AutotoolsPackage):
     """hsakmt is a thunk library that provides a userspace interface to amdkfd
     (AMD's HSA Linux kernel driver). It is the HSA equivalent of libdrm."""
 
@@ -33,9 +33,3 @@ class Hsakmt(Package):
     url      = "https://www.x.org/archive/individual/lib/hsakmt-1.0.0.tar.gz"
 
     version('1.0.0', '9beb20104e505300daf541266c4c3c3d')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/htop/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Htop(Package):
+class Htop(AutotoolsPackage):
     """htop is an interactive text-mode process viewer for Unix systems."""
 
     homepage = "https://github.com/hishamhm/htop"
@@ -34,8 +34,3 @@ class Htop(Package):
     version('2.0.2', '7d354d904bad591a931ad57e99fea84a')
 
     depends_on('ncurses')
-
-    def install(self, spec, prefix):
-        configure('--prefix=%s' % prefix)
-        make()
-        make('install')

var/spack/repos/builtin/packages/htslib/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Htslib(Package):
+class Htslib(AutotoolsPackage):
     """C library for high-throughput sequencing data formats."""
 
     homepage = "https://github.com/samtools/htslib"
@@ -34,8 +34,3 @@ class Htslib(Package):
     version('1.3.1', '16d78f90b72f29971b042e8da8be6843')
 
     depends_on('zlib')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-        make()
-        make('install')

var/spack/repos/builtin/packages/hwloc/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Hwloc(Package):
+class Hwloc(AutotoolsPackage):
     """The Portable Hardware Locality (hwloc) software package
        provides a portable abstraction (across OS, versions,
        architectures, ...) of the hierarchical topology of modern
@@ -53,9 +53,3 @@ class Hwloc(Package):
 
     def url_for_version(self, version):
         return "http://www.open-mpi.org/software/hwloc/v%s/downloads/hwloc-%s.tar.gz" % (version.up_to(2), version)
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-
-        make()
-        make("install")

var/spack/repos/builtin/packages/hydra/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Hydra(Package):
+class Hydra(AutotoolsPackage):
     """Hydra is a process management system for starting parallel jobs.
     Hydra is designed to natively work with existing launcher daemons
     (such as ssh, rsh, fork), as well as natively integrate with resource
@@ -37,9 +37,3 @@ class Hydra(Package):
     list_depth = 2
 
     version('3.2', '4d670916695bf7e3a869cc336a881b39')
-
-    def install(self, spec, prefix):
-        configure('--prefix=%s' % prefix)
-
-        make()
-        make("install")

var/spack/repos/builtin/packages/iceauth/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Iceauth(Package):
+class Iceauth(AutotoolsPackage):
     """The iceauth program is used to edit and display the authorization
     information used in connecting with ICE.   It operates very much
     like the xauth program for X11 connection authentication records."""
@@ -40,9 +40,3 @@ class Iceauth(Package):
     depends_on('xproto@7.0.22:', type='build')
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/ico/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Ico(Package):
+class Ico(AutotoolsPackage):
     """ico is a simple animation program that may be used for testing various
     X11 operations and extensions.  It displays a wire-frame rotating
     polyhedron, with hidden lines removed, or a solid-fill polyhedron with
@@ -41,9 +41,3 @@ class Ico(Package):
     depends_on('xproto@7.0.22:', type='build')
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/ilmbase/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Ilmbase(Package):
+class Ilmbase(AutotoolsPackage):
     """OpenEXR ILM Base libraries (high dynamic-range image file format)"""
 
     homepage = "http://www.openexr.com/"
@@ -36,7 +36,3 @@ class Ilmbase(Package):
     version('2.0.1', '74c0d0d2873960bd0dc1993f8e03f0ae')
     version('1.0.2', '26c133ee8ca48e1196fbfb3ffe292ab4')
     version('0.9.0', '4df45f8116cb7a013b286caf6da30a2e')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-        make('install')

var/spack/repos/builtin/packages/imake/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Imake(Package):
+class Imake(AutotoolsPackage):
     """The imake build system."""
 
     homepage = "http://www.snake.net/software/imake-stuff/"
@@ -35,9 +35,3 @@ class Imake(Package):
 
     depends_on('xproto', type='build')
     depends_on('pkg-config@0.9.0:', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/inputproto/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Inputproto(Package):
+class Inputproto(AutotoolsPackage):
     """X Input Extension.
 
     This extension defines a protocol to provide additional input devices
@@ -38,8 +38,3 @@ class Inputproto(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make('install')

var/spack/repos/builtin/packages/intel-gpu-tools/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class IntelGpuTools(Package):
+class IntelGpuTools(AutotoolsPackage):
     """Intel GPU Tools is a collection of tools for development and testing of
     the Intel DRM driver. There are many macro-level test suites that get used
     against the driver, including xtest, rendercheck, piglit, and oglconform,
@@ -58,10 +58,3 @@ class IntelGpuTools(Package):
     # python-docutils
     # x11proto-dri2-dev
     # xutils-dev
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('check')
-        make('install')

var/spack/repos/builtin/packages/itstool/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Itstool(Package):
+class Itstool(AutotoolsPackage):
     """ITS Tool allows you to translate your XML documents with PO files, using
        rules from the W3C Internationalization Tag Set (ITS) to determine what
        to translate and how to separate it into PO file messages."""
@@ -37,8 +37,3 @@ class Itstool(Package):
     version('2.0.1', '40935cfb08228488bd45575e5f001a34')
     version('2.0.0', 'd8c702c3e8961db83d04182c2aa4730b')
     version('1.2.0', 'c0925f6869e33af8e7fe56848c129152')
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-        make()
-        make('install')

var/spack/repos/builtin/packages/jpeg/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Jpeg(Package):
+class Jpeg(AutotoolsPackage):
     """libjpeg is a widely used free library with functions for handling the
     JPEG image data format. It implements a JPEG codec (encoding and decoding)
     alongside various utilities for handling JPEG data."""
@@ -35,10 +35,3 @@ class Jpeg(Package):
 
     version('9b', '6a9996ce116ec5c52b4870dbcd6d3ddb')
     version('9a', '3353992aecaee1805ef4109aadd433e7')
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-
-        make()
-        make("test")
-        make("install")

var/spack/repos/builtin/packages/judy/package.py

@@ -25,16 +25,11 @@
 from spack import *
 
 
-class Judy(Package):
+class Judy(AutotoolsPackage):
     """Judy: General-purpose dynamic array, associative array and hash-trie."""
     homepage = "http://judy.sourceforge.net/"
     url      = "http://downloads.sourceforge.net/project/judy/judy/Judy-1.0.5/Judy-1.0.5.tar.gz"
 
     version('1.0.5', '115a0d26302676e962ae2f70ec484a54')
+
     parallel = False
-
-    def install(self, spec, prefix):
-        configure('--prefix=%s' % prefix)
-
-        make()
-        make("install")

var/spack/repos/builtin/packages/kbproto/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Kbproto(Package):
+class Kbproto(AutotoolsPackage):
     """X Keyboard Extension.
 
     This extension defines a protcol to provide a number of new capabilities
@@ -38,8 +38,3 @@ class Kbproto(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make('install')

var/spack/repos/builtin/packages/lbxproxy/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Lbxproxy(Package):
+class Lbxproxy(AutotoolsPackage):
     """lbxproxy accepts client connections, multiplexes them over a single
     connection to the X server, and performs various optimizations on the
     X protocol to make it faster over low bandwidth and/or high latency
@@ -50,9 +50,3 @@ class Lbxproxy(Package):
     depends_on('bigreqsproto', type='build')
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/lcms/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Lcms(Package):
+class Lcms(AutotoolsPackage):
     """Little cms is a color management library. Implements fast
        transforms between ICC profiles. It is focused on speed, and is
        portable across several platforms (MIT license)."""
@@ -37,8 +37,3 @@ class Lcms(Package):
     depends_on("jpeg")
     depends_on("libtiff")
     depends_on("zlib")
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/libapplewm/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libapplewm(Package):
+class Libapplewm(AutotoolsPackage):
     """AppleWM is a simple library designed to interface with the Apple-WM
     extension. This extension allows X window managers to better interact with
     the Mac OS X Aqua user interface when running X11 in a rootless mode."""
@@ -43,12 +43,6 @@ class Libapplewm(Package):
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
 
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
     # Crashes with this error message on Linux:
     # HIServices/Processes.h: No such file or directory
     # May only build properly on macOS?
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/libarchive/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libarchive(Package):
+class Libarchive(AutotoolsPackage):
     """libarchive: C library and command-line tools for reading and
        writing tar, cpio, zip, ISO, and other archive formats."""
 
@@ -48,10 +48,5 @@ class Libarchive(Package):
     depends_on('libxml2')
     depends_on('expat')
 
-    def install(self, spec, prefix):
+    # NOTE: `make check` is known to fail with the Intel compilers
-        configure('--prefix={0}'.format(prefix))
+    # The build test suite cannot be built with Intel
-
-        make()
-        if self.run_tests:
-            make('check')  # cannot build test suite with Intel compilers
-        make('install')

var/spack/repos/builtin/packages/libcerf/package.py

@@ -26,7 +26,7 @@
 from spack import *
 
 
-class Libcerf(Package):
+class Libcerf(AutotoolsPackage):
     """A self-contained C library providing complex error functions, based
        on Faddeeva's plasma dispersion function w(z). Also provides Dawson's
        integral and Voigt's convolution of a Gaussian and a Lorentzian
@@ -37,13 +37,11 @@ class Libcerf(Package):
 
     version('1.3', 'b3504c467204df71e62aeccf73a25612')
 
-    def install(self, spec, prefix):
+    def configure_args(self):
         options = []
         # Clang reports unused functions as errors, see
         # http://clang.debian.net/status.php?version=3.8.1&key=UNUSED_FUNCTION
         if spec.satisfies('%clang'):
             options.append('CFLAGS=-Wno-unused-function')
 
-        configure('--prefix=%s' % prefix, *options)
+        return options
-        make()
-        make("install")

var/spack/repos/builtin/packages/libcircle/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libcircle(Package):
+class Libcircle(AutotoolsPackage):
     """libcircle provides an efficient distributed queue on a cluster,
        using self-stabilizing work stealing."""
 
@@ -35,8 +35,3 @@ class Libcircle(Package):
             url='https://github.com/hpc/libcircle/releases/download/0.2.1-rc.1/libcircle-0.2.1-rc.1.tar.gz')
 
     depends_on('mpi')
-
-    def install(self, spec, prefix):
-        configure("--prefix=" + prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/libdmx/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libdmx(Package):
+class Libdmx(AutotoolsPackage):
     """libdmx - X Window System DMX (Distributed Multihead X) extension
     library."""
 
@@ -41,9 +41,3 @@ class Libdmx(Package):
     depends_on('dmxproto@2.2.99.1:', type='build')
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/libedit/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libedit(Package):
+class Libedit(AutotoolsPackage):
     """An autotools compatible port of the NetBSD editline library"""
     homepage = "http://thrysoee.dk/editline/"
     url      = "http://thrysoee.dk/editline/libedit-20150325-3.1.tar.gz"
@@ -34,9 +34,3 @@ class Libedit(Package):
             url="http://thrysoee.dk/editline/libedit-20150325-3.1.tar.gz")
 
     depends_on('ncurses')
-
-    def install(self, spec, prefix):
-        configure('--prefix=%s' % prefix)
-
-        make()
-        make("install")

var/spack/repos/builtin/packages/libepoxy/package.py

@@ -25,15 +25,10 @@
 from spack import *
 
 
-class Libepoxy(Package):
+class Libepoxy(AutotoolsPackage):
     """Epoxy is a library for handling OpenGL function pointer management for
     you."""
     homepage = "https://github.com/anholt/libepoxy"
     url      = "https://github.com/anholt/libepoxy/releases/download/v1.3.1/libepoxy-1.3.1.tar.bz2"
 
     version('1.3.1', '96f6620a9b005a503e7b44b0b528287d')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-        make()
-        make('install')

var/spack/repos/builtin/packages/libevent/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libevent(Package):
+class Libevent(AutotoolsPackage):
     """The libevent API provides a mechanism to execute a callback function
        when a specific event occurs on a file descriptor or after a
        timeout has been reached. Furthermore, libevent also support
@@ -52,13 +52,11 @@ class Libevent(Package):
             description="Build with encryption enabled at the libevent level.")
     depends_on('openssl', when='+openssl')
 
-    def install(self, spec, prefix):
+    def configure_args(self):
         configure_args = []
         if '+openssl' in spec:
             configure_args.append('--enable-openssl')
         else:
             configure_args.append('--enable-openssl')
 
-        configure("--prefix=%s" % prefix, *configure_args)
+        return configure_args
-        make()
-        make("install")

var/spack/repos/builtin/packages/libfontenc/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libfontenc(Package):
+class Libfontenc(AutotoolsPackage):
     """libfontenc - font encoding library."""
 
     homepage = "http://cgit.freedesktop.org/xorg/lib/libfontenc"
@@ -38,9 +38,3 @@ class Libfontenc(Package):
     depends_on('xproto', type='build')
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/libfs/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libfs(Package):
+class Libfs(AutotoolsPackage):
     """libFS - X Font Service client library.
 
     This library is used by clients of X Font Servers (xfs), such as
@@ -41,9 +41,3 @@ class Libfs(Package):
     depends_on('xtrans', type='build')
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/libgcrypt/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libgcrypt(Package):
+class Libgcrypt(AutotoolsPackage):
     """Libgcrypt is a general purpose cryptographic library based on
        the code from GnuPG. It provides functions for all cryptographic
        building blocks: symmetric ciphers, hash algorithms, MACs, public
@@ -37,8 +37,3 @@ class Libgcrypt(Package):
     version('1.6.2', 'b54395a93cb1e57619943c082da09d5f')
 
     depends_on("libgpg-error")
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/libgd/package.py

@@ -26,7 +26,7 @@
 from spack import *
 
 
-class Libgd(Package):
+class Libgd(AutotoolsPackage):
     """GD is an open source code library for the dynamic creation of images
        by programmers. GD is written in C, and "wrappers" are available
        for Perl, PHP and other languages. GD creates PNG, JPEG, GIF,
@@ -55,7 +55,7 @@ class Libgd(Package):
     depends_on('libtiff')
     depends_on('fontconfig')
 
-    def install(self, spec, prefix):
+    def autoreconf(self, spec, prefix):
         autoreconf("--install", "--force",
                    "-I", "m4",
                    "-I", join_path(spec['gettext'].prefix,
@@ -67,6 +67,3 @@ def install(self, spec, prefix):
                    "-I", join_path(spec['libtool'].prefix,
                                    "share", "aclocal")
                    )
-        configure('--prefix={0}'.format(prefix))
-        make()
-        make("install")

var/spack/repos/builtin/packages/libgpg-error/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class LibgpgError(Package):
+class LibgpgError(AutotoolsPackage):
     """Libgpg-error is a small library that defines common error
        values for all GnuPG components. Among these are GPG, GPGSM,
        GPGME, GPG-Agent, libgcrypt, Libksba, DirMngr, Pinentry,
@@ -36,8 +36,3 @@ class LibgpgError(Package):
 
     version('1.21', 'ab0b5aba6d0a185b41d07bda804fd8b2')
     version('1.18', '12312802d2065774b787cbfc22cc04e9')
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/libgtextutils/package.py

@@ -25,16 +25,10 @@
 from spack import *
 
 
-class Libgtextutils(Package):
+class Libgtextutils(AutotoolsPackage):
     """Gordon's Text utils Library."""
 
     homepage = "https://github.com/agordon/libgtextutils"
     url      = "https://github.com/agordon/libgtextutils/releases/download/0.7/libgtextutils-0.7.tar.gz"
 
     version('0.7', '593c7c62e3c76ec49f5736eed4f96806')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/libhio/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libhio(Package):
+class Libhio(AutotoolsPackage):
     """
     A library for writing to hierarchical data store systems.
     """
@@ -38,8 +38,3 @@ class Libhio(Package):
     depends_on("libjson-c")
     depends_on("bzip2")
     depends_on("pkg-config", type="build")
-
-    def install(self, spec, prefix):
-        configure('--prefix=%s' % prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/libice/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libice(Package):
+class Libice(AutotoolsPackage):
     """libICE - Inter-Client Exchange Library."""
 
     homepage = "http://cgit.freedesktop.org/xorg/lib/libICE"
@@ -37,9 +37,3 @@ class Libice(Package):
     depends_on('xtrans', type='build')
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/libjpeg-turbo/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class LibjpegTurbo(Package):
+class LibjpegTurbo(AutotoolsPackage):
     """libjpeg-turbo is a fork of the original IJG libjpeg which uses SIMD to
        accelerate baseline JPEG compression and decompression. libjpeg is a
        library that implements JPEG image encoding, decoding and
@@ -43,8 +43,3 @@ class LibjpegTurbo(Package):
     # TODO: Implement the selection between two supported assemblers.
     # depends_on("yasm", type='build')
     depends_on("nasm", type='build')
-
-    def install(self, spec, prefix):
-        configure("--prefix=" + prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/liblbxutil/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Liblbxutil(Package):
+class Liblbxutil(AutotoolsPackage):
     """liblbxutil - Low Bandwith X extension (LBX) utility routines."""
 
     homepage = "http://cgit.freedesktop.org/xorg/lib/liblbxutil"
@@ -43,9 +43,3 @@ class Liblbxutil(Package):
     # undefined symbol: Xalloc
     # See https://bugs.freedesktop.org/show_bug.cgi?id=8421
     # Adding a dependency on libxdmcp and adding LIBS=-lXdmcp did not fix it
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/libmng/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libmng(Package):
+class Libmng(AutotoolsPackage):
     """libmng -THE reference library for reading, displaying, writing
        and examining Multiple-Image Network Graphics.  MNG is the animation
        extension to the popular PNG image-format."""
@@ -42,8 +42,3 @@ def patch(self):
         # jpeg requires stdio to beincluded before its headrs.
         filter_file(r'^(\#include \<jpeglib\.h\>)',
                     '#include<stdio.h>\n\\1', 'libmng_types.h')
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/libmonitor/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libmonitor(Package):
+class Libmonitor(AutotoolsPackage):
     """Libmonitor is a library for process and thread control."""
     homepage = "https://github.com/HPCToolkit/libmonitor"
     version('20130218', git='https://github.com/HPCToolkit/libmonitor.git',
@@ -36,8 +36,3 @@ class Libmonitor(Package):
     patch('libmonitorkrell-0000.patch', when='@20130218+krellpatch')
     patch('libmonitorkrell-0001.patch', when='@20130218+krellpatch')
     patch('libmonitorkrell-0002.patch', when='@20130218+krellpatch')
-
-    def install(self, spec, prefix):
-        configure("--prefix=" + prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/libnbc/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libnbc(Package):
+class Libnbc(AutotoolsPackage):
     """LibNBC is a prototypic implementation of a nonblocking
     interface for MPI collective operations. Based on ANSI C and
     MPI-1, it supports all MPI-1 collective operations in a
@@ -37,8 +37,3 @@ class Libnbc(Package):
     version('1.1.1', 'ece5c94992591a9fa934a90e5dbe50ce')
 
     depends_on("mpi")
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/liboldx/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Liboldx(Package):
+class Liboldx(AutotoolsPackage):
     """X version 10 backwards compatibility."""
 
     homepage = "https://cgit.freedesktop.org/xorg/lib/liboldX/"
@@ -37,9 +37,3 @@ class Liboldx(Package):
 
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/libpthread-stubs/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class LibpthreadStubs(Package):
+class LibpthreadStubs(AutotoolsPackage):
     """The libpthread-stubs package provides weak aliases for pthread
     functions not provided in libc or otherwise available by default."""
 
@@ -33,8 +33,3 @@ class LibpthreadStubs(Package):
     url      = "https://xcb.freedesktop.org/dist/libpthread-stubs-0.3.tar.gz"
 
     version('0.3', 'a09d928c4af54fe5436002345ef71138')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make('install')

var/spack/repos/builtin/packages/libsm/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libsm(Package):
+class Libsm(AutotoolsPackage):
     """libSM - X Session Management Library."""
 
     homepage = "http://cgit.freedesktop.org/xorg/lib/libSM"
@@ -39,9 +39,3 @@ class Libsm(Package):
     depends_on('xtrans', type='build')
     depends_on('pkg-config@0.9.0:', type='build')
     depends_on('util-macros', type='build')
-
-    def install(self, spec, prefix):
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        make('install')

var/spack/repos/builtin/packages/libsodium/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libsodium(Package):
+class Libsodium(AutotoolsPackage):
     """Sodium is a modern, easy-to-use software library for encryption,
     decryption, signatures, password hashing and more."""
     homepage = "https://download.libsodium.org/doc/"
@@ -44,9 +44,3 @@ def url_for_version(self, version):
         if version < Version('1.0.4'):
             url += 'old/'
         return url + 'libsodium-{0}.tar.gz'.format(version)
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-
-        make()
-        make("install")

var/spack/repos/builtin/packages/libunistring/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libunistring(Package):
+class Libunistring(AutotoolsPackage):
     """This library provides functions for manipulating Unicode strings
     and for manipulating C strings according to the Unicode standard."""
 
@@ -34,9 +34,4 @@ class Libunistring(Package):
 
     version('0.9.6', 'cb09c398020c27edac10ca590e9e9ef3')
 
-    def install(self, spec, prefix):
+    # NOTE: `make check` fails test-verify
-        configure('--prefix={0}'.format(prefix))
-
-        make()
-        # make('check')  # test-verify fails for me, contacted developers
-        make('install')

var/spack/repos/builtin/packages/libunwind/package.py

@@ -25,15 +25,10 @@
 from spack import *
 
 
-class Libunwind(Package):
+class Libunwind(AutotoolsPackage):
     """A portable and efficient C programming interface (API) to determine
        the call-chain of a program."""
     homepage = "http://www.nongnu.org/libunwind/"
     url      = "http://download.savannah.gnu.org/releases/libunwind/libunwind-1.1.tar.gz"
 
     version('1.1', 'fb4ea2f6fbbe45bf032cd36e586883ce')
-
-    def install(self, spec, prefix):
-        configure("--prefix=" + prefix)
-        make()
-        make("install")

var/spack/repos/builtin/packages/libuuid/package.py

@@ -25,16 +25,10 @@
 from spack import *
 
 
-class Libuuid(Package):
+class Libuuid(AutotoolsPackage):
     """Portable uuid C library"""
 
     homepage = "http://sourceforge.net/projects/libuuid/"
     url      = "http://downloads.sourceforge.net/project/libuuid/libuuid-1.0.3.tar.gz?r=http%3A%2F%2Fsourceforge.net%2Fprojects%2Flibuuid%2F&ts=1433881396&use_mirror=iweb"
 
     version('1.0.3', 'd44d866d06286c08ba0846aba1086d68')
-
-    def install(self, spec, prefix):
-        configure("--prefix=%s" % prefix)
-
-        make()
-        make("install")

var/spack/repos/builtin/packages/libuv/package.py

@@ -25,7 +25,7 @@
 from spack import *
 
 
-class Libuv(Package):
+class Libuv(AutotoolsPackage):
     """Multi-platform library with a focus on asynchronous IO"""
     homepage = "http://libuv.org"
     url      = "https://github.com/libuv/libuv/archive/v1.9.0.tar.gz"
@@ -36,11 +36,6 @@ class Libuv(Package):
     depends_on('autoconf', type='build')
     depends_on('libtool', type='build')
 
-    def install(self, spec, prefix):
+    def autoreconf(self, spec, prefix):
         bash = which("bash")
         bash('autogen.sh')
-        configure('--prefix=%s' % prefix)
-
-        make()
-        make("check")
-        make("install")