zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pinentry: old to new test API (#45011)

Browse Source 
* pinentry: New API
* move code around
* added back version check
* Complete check_version refactor
* Honor original handling of guis (i.e., don't try if not there)

---------

Co-authored-by: Tamara Dahlgren <dahlgren1@llnl.gov>
This commit is contained in:
AcriusWinter 2024-07-26 13:07:06 -07:00 committed by GitHub
parent 3180b28d76
commit 057b415074
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 18 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
var/spack/repos/builtin/packages/pinentry/package.py
View File

@ -3,7 +3,6 @@
# #
# SPDX-License-Identifier: (Apache-2.0 OR MIT) # SPDX-License-Identifier: (Apache-2.0 OR MIT)
from spack.package import * from spack.package import *
@ -95,17 +94,24 @@ def configure_args(self):
args.append("--enable-pinentry-" + gui) args.append("--enable-pinentry-" + gui)
else: else:
args.append("--disable-pinentry-" + gui) args.append("--disable-pinentry-" + gui)
return args return args
def test(self): def check_version(self, exe_name):
kwargs = { """Version check"""
"exe": self.prefix.bin.pinentry, exe = which(join_path(self.prefix.bin, exe_name))
"options": ["--version"], out = exe("--version", output=str.split, error=str.split)
"expected": [str(self.version)], assert str(self.version) in out
}
self.run_test(**kwargs) def test_pinentry(self):
"""Confirm pinentry version"""
self.check_version("pinentry")
def test_guis(self):
"""Check gui versions"""
for gui in self.supported_guis: for gui in self.supported_guis:
if "gui=" + gui in self.spec: if f"gui={gui}" not in self.spec:
kwargs["exe"] = self.prefix.bin.pinentry + "-" + gui continue
self.run_test(**kwargs)
exe_name = f"pinentry-{gui}"
with test_part(self, f"test_guis_{gui}", purpose=f"Check {exe_name} version"):
self.check_version(exe_name)