Add universal build_type variant to CMakePackage (#4797)

* Add universal build_type variant to CMakePackage
* Override build_type in some packages with different possible values
* Remove reference to no longer existent debug variant
* Update CBTF packages with new build_type variant
* Keep note on build size of LLVM

var/spack/repos/builtin/packages/alquimia/package.py

@@ -36,8 +36,6 @@ class Alquimia(CMakePackage):
 
     variant('shared', default=True,
             description='Enables the build of shared libraries')
-    variant('debug',  default=False,
-            description='Builds a debug version of the libraries')
 
     depends_on('mpi')
     depends_on('hdf5')
@@ -52,10 +50,6 @@ def cmake_args(self):
         options = ['-DCMAKE_C_COMPILER=%s' % spec['mpi'].mpicc,
                    '-DCMAKE_Fortran_COMPILER=%s' % spec['mpi'].mpifc,
                    '-DUSE_XSDK_DEFAULTS=YES',
-                   '-DCMAKE_BUILD_TYPE:STRING=%s' % (
-                       'DEBUG' if '+debug' in spec else 'RELEASE'),
-                   '-DXSDK_ENABLE_DEBUG:STRING=%s' % (
-                       'YES' if '+debug' in spec else 'NO'),
                    '-DBUILD_SHARED_LIBS:BOOL=%s' % (
                        'ON' if '+shared' in spec else 'OFF'),
                    '-DTPL_ENABLE_MPI:BOOL=ON',