Add universal build_type variant to CMakePackage (#4797)

* Add universal build_type variant to CMakePackage
* Override build_type in some packages with different possible values
* Remove reference to no longer existent debug variant
* Update CBTF packages with new build_type variant
* Keep note on build size of LLVM

var/spack/repos/builtin/packages/quinoa/package.py

@@ -38,8 +38,6 @@ class Quinoa(CMakePackage):
 
     version('develop', git='https://github.com/quinoacomputing/quinoa', branch='master')
 
-    variant('debug', default=False, description='Build debug version')
-
     depends_on('hdf5+mpi')
     depends_on("charm backend=mpi")
     depends_on("trilinos+exodus")
@@ -56,10 +54,3 @@ class Quinoa(CMakePackage):
     depends_on("pegtl")
 
     root_cmakelists_dir = 'src'
-
-    def build_type(self):
-        spec = self.spec
-        if '+debug' in spec:
-            return 'Debug'
-        else:
-            return 'Release'