zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Attributes for directives need to be set at class construction time. (#1718)

Browse Source 
- moved ensure_dicts() call from Package.__init__ to
  Package.__metaclass__.
This commit is contained in:
Todd Gamblin 2016-09-02 15:10:30 -07:00 committed by GitHub
parent ea6143402f
commit 07fa1cd5f8
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/spack/spack/package.py
View File

@ -329,6 +329,12 @@ class SomePackage(Package):
""" """
sanity_check_is_dir = [] sanity_check_is_dir = []
class __metaclass__(type):
"""Ensure attributes required by Spack directives are present."""
def __init__(cls, name, bases, dict):
type.__init__(cls, name, bases, dict)
spack.directives.ensure_dicts(cls)
def __init__(self, spec): def __init__(self, spec):
# this determines how the package should be built. # this determines how the package should be built.
self.spec = spec self.spec = spec
@ -342,9 +348,6 @@ def __init__(self, spec):
# Allow custom staging paths for packages # Allow custom staging paths for packages
self.path = None self.path = None
# Sanity check attributes required by Spack directives.
spack.directives.ensure_dicts(type(self))
# Check versions in the versions dict. # Check versions in the versions dict.
for v in self.versions: for v in self.versions:
assert (isinstance(v, Version)) assert (isinstance(v, Version))