zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Display warnings if no errors are found in build log

Browse Source
This commit is contained in:
Adam J. Stewart 2018-05-25 12:05:40 -05:00 committed by Todd Gamblin
parent f97550e149
commit 0b0887f48f
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/spack/spack/build_environment.py
View File

@ -907,16 +907,25 @@ def long_message(self):
if (self.module, self.name) in ChildError.build_errors: if (self.module, self.name) in ChildError.build_errors:
# The error happened in some external executed process. Show # The error happened in some external executed process. Show
# the build log with errors highlighted. # the build log with errors or warnings highlighted.
if self.build_log and os.path.exists(self.build_log): if self.build_log and os.path.exists(self.build_log):
errors, warnings = parse_log_events(self.build_log) errors, warnings = parse_log_events(self.build_log)
nerr = len(errors) nerr = len(errors)
nwar = len(warnings)
if nerr > 0: if nerr > 0:
# If errors are found, only display errors
if nerr == 1: if nerr == 1:
out.write("\n1 error found in build log:\n") out.write("\n1 error found in build log:\n")
else: else:
out.write("\n%d errors found in build log:\n" % nerr) out.write("\n%d errors found in build log:\n" % nerr)
out.write(make_log_context(errors)) out.write(make_log_context(errors))
elif nwar > 0:
# If no errors are found but warnings are, display warnings
if nwar == 1:
out.write("\n1 warning found in build log:\n")
else:
out.write("\n%d warnings found in build log:\n" % nwar)
out.write(make_log_context(warnings))
else: else:
# The error happened in in the Python code, so try to show # The error happened in in the Python code, so try to show