zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

spindle: It seems it needs mpi.h to compile, adding depends on mpi. (#26151)

Browse Source 
Workaround this compile error for gcc by adding -Wno-narrowing for it:
spindle_logd.cc:65:76: error: narrowing conversion of '255' from 'int' to 'char'
spindle_logd.cc:65:76: error: narrowing conversion of '223' from 'int' to 'char'
spindle_logd.cc:65:76: error: narrowing conversion of '191' from 'int' to 'char'

spindle 0.8.1 wants to compile tests with mpi.h, newer versions need mpicc,
thus add: depends_on("mpi"). Spindle supports the --no-mpi to disable MPI.
This commit is contained in:
bernhardkaindl 2021-09-27 17:58:47 +02:00 committed by GitHub
parent ffedc3637c
commit 0cc80f5118
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
var/spack/repos/builtin/packages/spindle/package.py
View File

@ -13,8 +13,21 @@ class Spindle(AutotoolsPackage):
linked libraries, causing site-wide performance problems.
"""
homepage = "https://computing.llnl.gov/project/spindle/"
url = "https://github.com/hpc/Spindle/archive/v0.8.1.tar.gz"
url = "https://github.com/hpc/Spindle/archive/v0.12.tar.gz"
version('0.12', sha256='3fd9d0afefa9072fffdf2cfd80a0b5e557e201a0b0eb02e7379eae65e64eb1f2')
version('0.8.1', sha256='c1e099e913faa8199be5811dc7b8be0266f0d1fd65f0a3a25bb46fbc70954ed6')
depends_on("launchmon")
# All versions provide the runtime option --no-mpi to not use MPI, but mpi
# is needed for the build:
# 0.8.1 wants to compile tests with mpi.h, newer versions need mpicc
depends_on("mpi")
# Workaround for:
# spindle_logd.cc:65:76: error: narrowing conversion of '255' from 'int' to 'char'
# spindle_logd.cc:65:76: error: narrowing conversion of '223' from 'int' to 'char'
# spindle_logd.cc:65:76: error: narrowing conversion of '191' from 'int' to 'char'
@when('@0.8.1 %gcc')
def setup_build_environment(self, env):
env.append_flags('CPPFLAGS', '-Wno-narrowing')