zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hsakmt-roct: remove use of deprecated run_test method (#45763)

Browse Source 
* hsakmt-roct: new test API
* hsakmt-roct: minor change to check_install script variable name

---------

Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
This commit is contained in:
AcriusWinter 2024-08-19 12:20:54 -07:00 committed by GitHub
parent ad6c7380c5
commit 0d668e4e92
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
var/spack/repos/builtin/packages/hsakmt-roct/package.py
View File

@ -89,9 +89,9 @@ def cmake_args(self):
@run_after("install") @run_after("install")
@on_package_attributes(run_tests=True) @on_package_attributes(run_tests=True)
def check_install(self): def check_install(self):
test_dir = "tests/kfdtest" """Check if package is installed correctly"""
test_dir = join_path("tests", "kfdtest")
with working_dir(test_dir, create=True): with working_dir(test_dir, create=True):
cmake_bin = join_path(self.spec["cmake"].prefix.bin, "cmake")
prefixes = ";".join( prefixes = ";".join(
[ [
self.spec["libdrm"].prefix, self.spec["libdrm"].prefix,
@ -109,9 +109,12 @@ def check_install(self):
"-DLIBHSAKMT_PATH=" + hsakmt_path, "-DLIBHSAKMT_PATH=" + hsakmt_path,
".", ".",
] ]
self.run_test(cmake_bin, cc_options) cmake = self.spec["cmake"].command
cmake(*cc_options)
make = which("make")
make() make()
os.environ["LD_LIBRARY_PATH"] = hsakmt_path os.environ["LD_LIBRARY_PATH"] = hsakmt_path
os.environ["BIN_DIR"] = os.getcwd() os.environ["BIN_DIR"] = os.getcwd()
self.run_test("scripts/run_kfdtest.sh") run_kfdtest = which(join_path("scripts", "run_kfdtest.sh"))
run_kfdtest()
make("clean") make("clean")