zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

binutils: add option for assembler, constrain 'as' and 'ld' variants (#23065)

Browse Source 
Avoid that the user builds the assembler without the linker, because you
may run into problems when the host linker is old:

https://wiki.gentoo.org/wiki/Binutils_2.32_upgrade_notes/elfutils_0.175:_unable_to_initialize_decompress_status_for_section_.debug_info
This commit is contained in:
Harmen Stoppels 2021-04-19 11:55:39 +02:00 committed by GitHub
parent 618edbe5d5
commit 0f47464df4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
var/spack/repos/builtin/packages/binutils/package.py
View File

@ -39,6 +39,7 @@ class Binutils(AutotoolsPackage, GNUMirrorPackage):
variant('headers', default=False, description='Install extra headers (e.g. ELF)') variant('headers', default=False, description='Install extra headers (e.g. ELF)')
variant('lto', default=False, description='Enable lto.') variant('lto', default=False, description='Enable lto.')
variant('ld', default=False, description='Enable ld.') variant('ld', default=False, description='Enable ld.')
variant('gas', default=False, description='Enable as assembler.')
variant('interwork', default=False, description='Enable interwork.') variant('interwork', default=False, description='Enable interwork.')
patch('cr16.patch', when='@:2.29.1') patch('cr16.patch', when='@:2.29.1')
@ -60,6 +61,15 @@ class Binutils(AutotoolsPackage, GNUMirrorPackage):
conflicts('+gold', when='platform=darwin', conflicts('+gold', when='platform=darwin',
msg="Binutils cannot build linkers on macOS") msg="Binutils cannot build linkers on macOS")
# When you build binutils with ~ld and +gas and load it in your PATH, you may
# end up with an incompatibility between linker and assembler, in particular:
# "unable to initialize decompress status for section .debug_info" is the error
# I've encountered.
conflicts('~gas', '+ld', msg="Linker and assembler should be the same version")
conflicts('+gas', '~ld', msg="Linker and assembler should be the same version")
conflicts('~gas', '+gold', msg="Linker and assembler should be the same version")
conflicts('+gas', '~gold', msg="Linker and assembler should be the same version")
def configure_args(self): def configure_args(self):
spec = self.spec spec = self.spec
@ -76,6 +86,7 @@ def configure_args(self):
args += self.enable_or_disable('lto') args += self.enable_or_disable('lto')
args += self.enable_or_disable('ld') args += self.enable_or_disable('ld')
args += self.enable_or_disable('gas')
args += self.enable_or_disable('interwork') args += self.enable_or_disable('interwork')
args += self.enable_or_disable('gold') args += self.enable_or_disable('gold')
args += self.enable_or_disable('plugins') args += self.enable_or_disable('plugins')