zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

env: bugfix: spack env list won't fail if var/spack/environments doesn't exist

Browse Source
This commit is contained in:
Todd Gamblin 2018-10-11 00:35:06 -07:00
parent ce230fa3f4
commit 15c5c36eaf
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/spack/spack/environment.py
View File

@ -155,10 +155,15 @@ def config_dict(yaml_data):
def list_environments(): def list_environments():
"""List the names of environments that currently exist.""" """List the names of environments that currently exist."""
# just return empty if the env path does not exist. A read-only
# operation like list should not try to create a directory.
if not os.path.exists(env_path):
return []
candidates = sorted(os.listdir(env_path)) candidates = sorted(os.listdir(env_path))
names = [] names = []
for candidate in candidates: for candidate in candidates:
yaml_path = os.path.join(env_path, candidate, env_yaml_name) yaml_path = os.path.join(root(candidate), env_yaml_name)
if valid_env_name(candidate) and os.path.exists(yaml_path): if valid_env_name(candidate) and os.path.exists(yaml_path):
names.append(candidate) names.append(candidate)
return names return names