From 1a42bf043fe1235b6958d63c4945cb59d5cd502a Mon Sep 17 00:00:00 2001 From: Matthew Lesko Date: Fri, 14 Feb 2025 00:44:12 -0500 Subject: [PATCH] openblas: .libs() uses self.libraries attribute (#48942) Currently this is hardcoded to the same value as listed in the class definition. If one ever overrides this attribute, such as: ``` packages: openblas: package_attributes: libraries = [ 'libopenblaso64', ] ``` this patch will make sure that override also in the `spec['openblas'].libs()` call. (Which happens in `hypre`, likely others). ( see https://spack.readthedocs.io/en/latest/packages_yaml.html#assigning-package-attributes ) Thanks to becker33 for debugging help in Slack --- var/spack/repos/builtin/packages/openblas/package.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/var/spack/repos/builtin/packages/openblas/package.py b/var/spack/repos/builtin/packages/openblas/package.py index a47004a5246..6ddbae7f306 100644 --- a/var/spack/repos/builtin/packages/openblas/package.py +++ b/var/spack/repos/builtin/packages/openblas/package.py @@ -322,7 +322,7 @@ def libs(self): spec = self.spec # Look for openblas{symbol_suffix} - name = ["libopenblas", "openblas"] + name = self.libraries search_shared = bool(spec.variants["shared"].value) suffix = spec.variants["symbol_suffix"].value if suffix != "none":