zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Run flake8 checks on changed uncommitted files

Browse Source
This commit is contained in:
Adam J. Stewart 2016-08-09 11:09:17 -05:00
parent e6a122417a
commit 1edfc82123
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
share/spack/qa/run-flake8
View File

@ -17,11 +17,18 @@ if [[ ! $flake8 ]]; then
exit 1 exit 1
fi fi
# Check if changed files are flake8 conformant [framework] # Add changed files that have been committed since branching off of develop
changed=$(git diff --name-only --find-renames develop... | grep '.py$') changed=($(git diff --name-only --find-renames develop... -- '*.py'))
# Add changed files that have been staged but not yet committed
changed+=($(git diff --name-only --find-renames --cached -- '*.py'))
# Add changed files that are unstaged
changed+=($(git diff --name-only --find-renames -- '*.py'))
# Ensure that each file in the array is unique
changed=($(printf '%s\n' "${changed[@]}" | sort -u))
# Add approved style exemptions to the changed packages. # Add approved style exemptions to the changed packages.
for file in $changed; do for file in "${changed[@]}"; do
# Make a backup to restore later # Make a backup to restore later
cp "$file" "$file.sbak~" cp "$file" "$file.sbak~"
@ -48,14 +55,14 @@ for file in $changed; do
done done
return_code=0 return_code=0
if [[ $changed ]]; then if [[ "${changed[@]}" ]]; then
echo ======================================================= echo =======================================================
echo flake8: running flake8 code checks on spack. echo flake8: running flake8 code checks on spack.
echo echo
echo Modified files: echo Modified files:
echo $changed | perl -pe 's/^/ /;s/ +/\n /g' echo "${changed[@]}" | perl -pe 's/^/ /;s/ +/\n /g'
echo ======================================================= echo =======================================================
if flake8 --format pylint $changed; then if flake8 --format pylint "${changed[@]}"; then
echo "Flake8 checks were clean." echo "Flake8 checks were clean."
else else
echo "Flake8 found errors." echo "Flake8 found errors."
@ -66,7 +73,7 @@ else
fi fi
# Restore original package files after modifying them. # Restore original package files after modifying them.
for file in $changed; do for file in "${changed[@]}"; do
if [[ -e "${file}.sbak~" ]]; then if [[ -e "${file}.sbak~" ]]; then
mv "${file}.sbak~" "${file}" mv "${file}.sbak~" "${file}"
fi fi