zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tar: conditionally link iconv (#47933)

Browse Source 
* fix broken packages requiring iconv

* tar: -liconv only when libiconv

* Revert "fix broken packages requiring iconv"

This reverts commit 5fa426b52f.

---------

Co-authored-by: Harmen Stoppels <me@harmenstoppels.nl>
This commit is contained in:
Kin Fai Tse 2024-12-06 00:09:18 +08:00 committed by GitHub
parent 3fcc38ef04
commit 1f2a68f2b6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
var/spack/repos/builtin/packages/tar/package.py
View File

@ -72,7 +72,7 @@ def determine_version(cls, exe):
return match.group(1) if match else None
def flag_handler(self, name, flags):
if name == "ldflags" and self.spec.satisfies("@1.35"):
if name == "ldflags" and self.spec.satisfies("@1.35 ^[virtuals=iconv] libiconv"):
# https://savannah.gnu.org/bugs/?64441
flags.append("-liconv")
return (flags, None, None)