From 1f2a68f2b6da57f3a52c2ee9636f9a224df2abe0 Mon Sep 17 00:00:00 2001 From: Kin Fai Tse Date: Fri, 6 Dec 2024 00:09:18 +0800 Subject: [PATCH] tar: conditionally link iconv (#47933) * fix broken packages requiring iconv * tar: -liconv only when libiconv * Revert "fix broken packages requiring iconv" This reverts commit 5fa426b52fe163ea7e017ccbbb87deaf5f294800. --------- Co-authored-by: Harmen Stoppels --- var/spack/repos/builtin/packages/tar/package.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/var/spack/repos/builtin/packages/tar/package.py b/var/spack/repos/builtin/packages/tar/package.py index c293f620372..d583f7e32ac 100644 --- a/var/spack/repos/builtin/packages/tar/package.py +++ b/var/spack/repos/builtin/packages/tar/package.py @@ -72,7 +72,7 @@ def determine_version(cls, exe): return match.group(1) if match else None def flag_handler(self, name, flags): - if name == "ldflags" and self.spec.satisfies("@1.35"): + if name == "ldflags" and self.spec.satisfies("@1.35 ^[virtuals=iconv] libiconv"): # https://savannah.gnu.org/bugs/?64441 flags.append("-liconv") return (flags, None, None)