From 201f5bdfe8813e0b3995d72e07f00d8d7257586c Mon Sep 17 00:00:00 2001 From: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com> Date: Fri, 20 Aug 2021 05:27:12 -0700 Subject: [PATCH] WarpX: Actually skip tests when cannot be run (#25494) --- var/spack/repos/builtin/packages/warpx/package.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/var/spack/repos/builtin/packages/warpx/package.py b/var/spack/repos/builtin/packages/warpx/package.py index 03d0e3884df..b5cb9ef7efb 100644 --- a/var/spack/repos/builtin/packages/warpx/package.py +++ b/var/spack/repos/builtin/packages/warpx/package.py @@ -158,7 +158,7 @@ def check(self): """Checks after the build phase""" if '+app' not in self.spec: print("WarpX check skipped: requires variant +app") - pass + return with working_dir("spack-check", create=True): cli_args = self._get_input_options(False) @@ -175,7 +175,7 @@ def test(self): """Perform smoke tests on the installed package.""" if '+app' not in self.spec: print("WarpX smoke tests skipped: requires variant +app") - pass + return # our executable names are a variant-dependent and naming evolves exe = find(self.prefix.bin, 'warpx.*', recursive=False)[0]