zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

flux-sched: add patch for signedness compare issue on gcc@9.40 (#30514)

Browse Source 
Problem: GCC 9.4.0 catches a bad integer comparison in
resource/hlapi/bindings/c++/reapi_cli_impl.hpp in flux-sched@0.22.0
and current master.

Add a patch to work around the problem until an upstream fix is
available.
This commit is contained in:
Mark Grondona 2022-05-05 17:11:04 -07:00 committed by GitHub
parent b6e1cbd86d
commit 202214d855
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
var/spack/repos/builtin/packages/flux-sched/jobid-sign-compare-fix.patch Normal file
View File

@ -0,0 +1,13 @@
diff --git a/resource/hlapi/bindings/c++/reapi_cli_impl.hpp b/resource/hlapi/bindings/c++/reapi_cli_impl.hpp
index 0b01b341..e0a91458 100644
--- a/resource/hlapi/bindings/c++/reapi_cli_impl.hpp
+++ b/resource/hlapi/bindings/c++/reapi_cli_impl.hpp
@@ -594,7 +594,7 @@ int resource_query_t::remove_job (const uint64_t jobid)
{
int rc = -1;
- if (jobid > std::numeric_limits<int64_t>::max ()) {
+ if (jobid > (uint64_t) std::numeric_limits<int64_t>::max ()) {
errno = EOVERFLOW;
return rc;
}

1
var/spack/repos/builtin/packages/flux-sched/package.py
View File

@ -75,6 +75,7 @@ class FluxSched(AutotoolsPackage):
# Disable t5000-valgrind.t by default due to false positives not yet # Disable t5000-valgrind.t by default due to false positives not yet
# in the suppressions file. (This patch will be in v0.21.0) # in the suppressions file. (This patch will be in v0.21.0)
patch('no-valgrind.patch', when='@:0.20.0') patch('no-valgrind.patch', when='@:0.20.0')
patch('jobid-sign-compare-fix.patch', when='@:0.22.0')
def url_for_version(self, version): def url_for_version(self, version):
''' '''