zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix for sanity check failure in spack upstream code: atmi, hip-rocclr (#31454)

Browse Source 
* Fix for sanity check failure in spack upstream code

* Style check failure correction

* Correction as per the review comments
This commit is contained in:
renjithravindrankannath 2022-07-11 15:01:47 -07:00 committed by GitHub
parent 5f7f8ce1eb
commit 21822f233c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
var/spack/repos/builtin/packages/atmi/package.py
View File

@ -55,9 +55,12 @@ class Atmi(CMakePackage):
patch('0002-Remove-usr-bin-rsync-reference.patch', when='@4.0.0:')
def cmake_args(self):
return [
args = [
'-DROCM_VERSION={0}'.format(self.spec.version)
]
if self.spec.satisfies('@5.0.2:'):
args.append(self.define('FILE_REORG_BACKWARD_COMPATIBILITY', 'OFF'))
return args
@run_after('install')
def install_stub(self):

11
var/spack/repos/builtin/packages/hip-rocclr/package.py
View File

@ -107,12 +107,6 @@ def url_for_version(self, version):
when='@master'
)
@property
def install_targets(self):
if self.spec.satisfies('@4.5.0:'):
return []
return ['install']
@run_after('install')
def deploy_missing_files(self):
if '@3.5.0' in self.spec:
@ -135,3 +129,8 @@ def cmake_args(self):
'-DOPENCL_DIR={0}/opencl-on-vdi'.format(self.stage.source_path)
]
return args
def __init__(self, spec):
super(HipRocclr, self).__init__(spec)
if self.spec.satisfies('@4.5.0:'):
self.phases = ['cmake', 'build']