zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

py-cmake: only run test suite when run_tests (#43246)

Browse Source 
As the cmake build is triggered by scikit build, the usual spack option
for enabling tests had no effect and the heavy test suite ran all the time.

Used https://github.com/scikit-build/cmake-python-distributions/issues/172#issuecomment-890322263
to implement how to pass options to the actual `cmake` build.

I also excluded some tests that failed for me on alma9 (gcc 11.4.1),
so the rest of the test suite can be run.
This commit is contained in:
Valentin Volkl 2024-03-22 04:34:43 +01:00 committed by GitHub
parent d33e10a695
commit 2314aeb884
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
var/spack/repos/builtin/packages/py-cmake/package.py
View File

@ -53,3 +53,16 @@ class PyCmake(PythonPackage):
def install_options(self, spec, prefix):
return ["-DBUILD_CMAKE_FROM_SOURCE=ON", "-DCMakeProject_SOURCE_DIR=cmake-src"]
def setup_build_environment(self, env):
if self.run_tests:
env.set(
"SKBUILD_CONFIGURE_OPTIONS",
# BootstrapTest is already exlcude upstream,
# The rest are (non-understood) known failures, disabled to get test suite working
# todo: investigate test failures / check if still needed in newer versions
"-DRUN_CMAKE_TEST=ON -DRUN_CMAKE_TEST_EXCLUDE=BootstrapTest|CompileWarningAsError"
"|GET_RUNTIME_DEPENDENCIES",
)
else:
env.set("SKBUILD_CONFIGURE_OPTIONS", "-DRUN_CMAKE_TEST=OFF")