zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix improper type for InvalidDependencyError argument (#30504)

Browse Source
This commit is contained in:
Greg Becker 2022-05-06 07:23:12 -07:00 committed by GitHub
parent c2afb4b916
commit 27462bc982
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/spack/spack/solver/asp.py
View File

@ -1749,7 +1749,7 @@ def setup(self, driver, specs):
# Fail if we already know an unreachable node is requested
for spec in specs:
missing_deps = [d for d in spec.traverse()
missing_deps = [str(d) for d in spec.traverse()
if d.name not in possible and not d.virtual]
if missing_deps:
raise spack.spec.InvalidDependencyError(spec.name, missing_deps)

6
lib/spack/spack/test/cmd/env.py
View File

@ -1547,8 +1547,10 @@ def test_stack_yaml_force_remove_from_matrix(tmpdir):
def test_stack_concretize_extraneous_deps(tmpdir, config, mock_packages):
# FIXME: The new concretizer doesn't handle yet soft
# FIXME: constraints for stacks
if spack.config.get('config:concretizer') == 'clingo':
pytest.skip('Clingo concretizer does not support soft constraints')
# FIXME: This now works for statically-determinable invalid deps
# FIXME: But it still does not work for dynamically determined invalid deps
# if spack.config.get('config:concretizer') == 'clingo':
# pytest.skip('Clingo concretizer does not support soft constraints')
filename = str(tmpdir.join('spack.yaml'))
with open(filename, 'w') as f: