zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

benchmark: enable shared libraries by default (#47368)

Browse Source 
* benchmark: enable shared libraries by default

The existing behaviour of Google Benchmark yiels static objects which
are of little use for most projects. This PR changes the spec to use
dynamic libraries instead.

* Add shared variant
This commit is contained in:
Stephen Nicholas Swatman 2024-11-10 21:12:23 +01:00 committed by GitHub
parent 2713b0c216
commit 2da4366ba6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
var/spack/repos/builtin/packages/benchmark/package.py
View File

@ -14,6 +14,7 @@ class Benchmark(CMakePackage):
git = "https://github.com/google/benchmark.git"
license("Apache-2.0")
maintainers("stephenswat")
# first properly installed CMake config packages in
# 1.2.0 release: https://github.com/google/benchmark/issues/363
@ -54,6 +55,9 @@ class Benchmark(CMakePackage):
when="@1.5.4:",
description="Enable performance counters provided by libpfm",
)
variant(
"shared", default=True, sticky=True, description="Build the libraries as shared objects"
)
depends_on("cmake@2.8.11:", type="build", when="@:1.1.0")
depends_on("cmake@2.8.12:", type="build", when="@1.2.0:1.4")
@ -64,6 +68,7 @@ def cmake_args(self):
# No need for testing for the install
args = [
self.define("BENCHMARK_ENABLE_TESTING", False),
self.define_from_variant("BUILD_SHARED_LIBS", "shared"),
self.define_from_variant("BENCHMARK_ENABLE_LIBPFM", "performance_counters"),
]
return args