zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

eckit: skip broken test (#34610)

Browse Source
This commit is contained in:
Sergey Kosukhin 2022-12-21 20:20:05 +01:00 committed by GitHub
parent a6c2569b18
commit 2ef026b8c6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
var/spack/repos/builtin/packages/eckit/package.py
View File

@ -88,7 +88,7 @@ class Eckit(CMakePackage):
def cmake_args(self): def cmake_args(self):
args = [ args = [
# Some features that we want to build are experimental: # Some features that we want to build are experimental:
self.define("ENABLE_EXPERIMENTAL", True), self.define("ENABLE_EXPERIMENTAL", self._enable_experimental),
self.define_from_variant("ENABLE_BUILD_TOOLS", "tools"), self.define_from_variant("ENABLE_BUILD_TOOLS", "tools"),
# We let ecBuild find the MPI library. We could help it by setting # We let ecBuild find the MPI library. We could help it by setting
# CMAKE_C_COMPILER to mpicc but that might give CMake a wrong # CMAKE_C_COMPILER to mpicc but that might give CMake a wrong
@ -149,3 +149,22 @@ def cmake_args(self):
args.append(self.define("CURSES_NEED_NCURSES", True)) args.append(self.define("CURSES_NEED_NCURSES", True))
return args return args
def check(self):
ctest_args = ["-j", str(make_jobs)]
broken_tests = []
if self._enable_experimental:
# The following test quasi-randomly fails not because it reveals a bug in the library
# but because its implementation has a bug (static initialization order fiasco):
broken_tests.append("eckit_test_experimental_singleton_singleton")
if broken_tests:
ctest_args.extend(["-E", "|".join(broken_tests)])
with working_dir(self.build_directory):
ctest(*ctest_args)
@property
def _enable_experimental(self):
return "linalg=armadillo" in self.spec