zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix some things from review

Browse Source
This commit is contained in:
Philip Sakievich 2024-11-08 06:32:55 -07:00
parent 259a1d9268
commit 33ae096a8b
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lib/spack/spack/cmd/dev_build.py
View File

@ -17,7 +17,7 @@
from spack.cmd.common import arguments from spack.cmd.common import arguments
from spack.installer import PackageInstaller from spack.installer import PackageInstaller
description = "developer build: build from code in current working directory" description = "developer build: build from user managed code"
section = "build" section = "build"
level = "long" level = "long"
@ -54,6 +54,7 @@ def setup_parser(subparser):
help="do not display verbose build output while installing", help="do not display verbose build output while installing",
) )
subparser.add_argument( subparser.add_argument(
"-D",
"--drop-in", "--drop-in",
type=str, type=str,
dest="shell", dest="shell",
@ -115,10 +116,9 @@ def dev_build(self, args):
spec = dev_matches[0] spec = dev_matches[0]
else: else:
if not spec.versions.concrete_range_as_version: if not spec.versions.concrete_range_as_version:
tty.die( version = max(spec.package_class.versions.keys())
"spack dev-build spec must have a single, concrete version. " spec.versions = spack.version.VersionList([version])
"Did you forget a package version number?" tty.msg(f"Defaulting to highest version: {spec.name}@{version}")
)
source_path = args.source_path source_path = args.source_path
if source_path is None: if source_path is None:
@ -134,9 +134,9 @@ def dev_build(self, args):
tty.msg("Uninstall or try adding a version suffix for this dev build.") tty.msg("Uninstall or try adding a version suffix for this dev build.")
sys.exit(1) sys.exit(1)
# disable checksumming if requested # disable checksumming if requested
if args.no_checksum: if args.no_checksum:
spack.config.set("config:checksum", False, scope="command_line") spack.config.set("config:checksum", False, scope="command_line")
tests = False tests = False
if args.test == "all": if args.test == "all":