zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

roctracer: fixed a bug in how the external is identified (#33517)

Browse Source 
Make the package a proper ROCm package.
This commit is contained in:
Brian Van Essen 2022-12-15 14:29:36 -08:00 committed by GitHub
parent aa8e1ba606
commit 3477d578a3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
var/spack/repos/builtin/packages/roctracer-dev/package.py
View File

@ -8,7 +8,7 @@
from spack.package import * from spack.package import *
class RoctracerDev(CMakePackage): class RoctracerDev(CMakePackage, ROCmPackage):
"""ROC-tracer library: Runtimes Generic Callback/Activity APIs. """ROC-tracer library: Runtimes Generic Callback/Activity APIs.
The goal of the implementation is to provide a generic independent from The goal of the implementation is to provide a generic independent from
specific runtime profiler to trace API and asyncronous activity.""" specific runtime profiler to trace API and asyncronous activity."""
@ -81,7 +81,7 @@ class RoctracerDev(CMakePackage):
@classmethod @classmethod
def determine_version(cls, lib): def determine_version(cls, lib):
match = re.search(r"lib\S*\.so\.\d+\.\d+\.(\d)(\d\d)(\d\d)", lib) match = re.search(r"rocm-(\d+)\.(\d+)\.(\d)/lib/lib\S*\.so\.\d+\.\d+\.\d+", lib)
if match: if match:
ver = "{0}.{1}.{2}".format( ver = "{0}.{1}.{2}".format(
int(match.group(1)), int(match.group(2)), int(match.group(3)) int(match.group(1)), int(match.group(2)), int(match.group(3))
@ -90,10 +90,6 @@ def determine_version(cls, lib):
ver = None ver = None
return ver return ver
def setup_build_environment(self, build_env):
spec = self.spec
build_env.set("HIP_PATH", spec["hip"].prefix),
def patch(self): def patch(self):
filter_file( filter_file(
"${CMAKE_PREFIX_PATH}/hsa", "${CMAKE_PREFIX_PATH}/hsa",