zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

VTK-m: use conflict with virtuals variant with ROCm (#36845)

Browse Source
This commit is contained in:
kwryankrattiger 2023-04-14 09:55:46 -05:00 committed by GitHub
parent 32808f4fb5
commit 3710774d02
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
var/spack/repos/builtin/packages/vtk-m/package.py
View File

@ -64,7 +64,10 @@ class VtkM(CMakePackage, CudaPackage, ROCmPackage):
variant("logging", default=False, description="build logging support")
variant("ascent_types", default=True, description="build support for ascent types")
variant(
"virtuals", default=False, description="enable support for deprecated virtual functions"
"virtuals",
default=False,
description="enable support for deprecated virtual functions",
when="@:1.9",
)
variant("mpi", default=False, description="build mpi support")
variant("rendering", default=True, description="build rendering support")
@ -124,6 +127,7 @@ class VtkM(CMakePackage, CudaPackage, ROCmPackage):
conflicts("+rocm", when="@:1.6")
conflicts("+rocm", when="+cuda")
conflicts("+rocm", when="~kokkos", msg="VTK-m does not support HIP without Kokkos")
conflicts("+rocm", when="+virtuals", msg="VTK-m does not support virtual functions with ROCm")
# Can build +shared+cuda after @1.7:
conflicts("+shared", when="@:1.6 +cuda_native")
@ -251,8 +255,6 @@ def cmake_args(self):
# hip support
if "+rocm" in spec:
options.append("-DVTKm_NO_DEPRECATED_VIRTUAL:BOOL=ON")
archs = ",".join(self.spec.variants["amdgpu_target"].value)
options.append("-DCMAKE_HIP_ARCHITECTURES:STRING={0}".format(archs))