Merge pull request #1235 from davydden/pkg/p4est_run_tests

p4est: use run_tests instead of a variant

var/spack/repos/builtin/packages/p4est/package.py

@@ -24,15 +24,15 @@
 ##############################################################################
 from spack import *
 
+
 class P4est(Package):
-    """Dynamic management of a collection (a forest) of adaptive octrees in parallel"""
+    """Dynamic management of a collection (a forest) of adaptive octrees in
+    parallel"""
     homepage = "http://www.p4est.org"
     url      = "http://p4est.github.io/release/p4est-1.1.tar.gz"
 
     version('1.1', '37ba7f4410958cfb38a2140339dbf64f')
 
-    variant('tests', default=True, description='Run small tests')
-
     # build dependencies
     depends_on('automake', type='build')
     depends_on('autoconf', type='build')
@@ -44,7 +44,8 @@ class P4est(Package):
     depends_on('zlib')
 
     def install(self, spec, prefix):
-        options = ['--enable-mpi',
+        options = [
+            '--enable-mpi',
             '--enable-shared',
             '--disable-vtk-binary',
             '--without-blas',
@@ -59,11 +60,6 @@ def install(self, spec, prefix):
         configure('--prefix=%s' % prefix, *options)
 
         make()
-        # Make tests optional as sometimes mpiexec can't be run with an error:
-        # mpiexec has detected an attempt to run as root.
-        # Running at root is *strongly* discouraged as any mistake (e.g., in
-        # defining TMPDIR) or bug can result in catastrophic damage to the OS
-        # file system, leaving your system in an unusable state.
-        if '+tests' in self.spec:
+        if self.run_tests:
             make("check")
         make("install")