zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clean up some comments

Browse Source 
Signed-off-by: Todd Gamblin <tgamblin@llnl.gov>
This commit is contained in:
Todd Gamblin 2025-05-20 09:25:20 -07:00
parent 07a8f6235b
commit 37bb0843fd
No known key found for this signature in database
GPG Key ID: C16729F1AACF66C6
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/spack/spack/spec.py
View File

@ -3847,11 +3847,13 @@ def nodes():
nonlocal edge_list
nonlocal node_ids
# Level 0: root node
yield self._cmp_node # always yield the root (this node)
if not self._dependencies: # done if there are no dependencies
return
# first level: yield sorted direct dependencies (inlines first level of BFS)
# Level 1: direct dependencies
# we can yield these in sorted order without tracking visited nodes
deps_have_deps = False
sorted_l1_edges = self.edges_to_dependencies(depflag=dt.ALL)
if len(sorted_l1_edges) > 1:
@ -3865,10 +3867,12 @@ def nodes():
if not deps_have_deps: # done if level 1 specs have no dependencies
return
# second level: now it's general; we need full traverse() to track visited nodes
# Level 2: dependencies of direct dependencies
# now it's general; we need full traverse() to track visited nodes
l1_specs = [edge.spec for edge in sorted_l1_edges]
# node_ids generates consistent node ids based on BFS traversal order.
# the node_ids dict generates consistent ids based on BFS traversal order
# these are used to identify edges later
node_ids = collections.defaultdict(lambda: len(node_ids))
node_ids[id(self)] # self is 0
for spec in l1_specs: