From 37ea9657cfef1e836b9c390f013c7b378c2d0dde Mon Sep 17 00:00:00 2001 From: Massimiliano Culpo Date: Thu, 5 Sep 2024 12:10:59 +0200 Subject: [PATCH] Remove `test_external_package_module` (#46218) This test was possibly meant for the Cray platform, and currently is a no-op. Signed-off-by: Massimiliano Culpo --- lib/spack/spack/test/concretize.py | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/lib/spack/spack/test/concretize.py b/lib/spack/spack/test/concretize.py index 8e8e374fa83..b881241c42d 100644 --- a/lib/spack/spack/test/concretize.py +++ b/lib/spack/spack/test/concretize.py @@ -648,20 +648,6 @@ def test_external_package(self): assert "externalprereq" not in spec assert spec["externaltool"].compiler.satisfies("gcc") - def test_external_package_module(self): - # No tcl modules on darwin/linux machines - # and Windows does not (currently) allow for bash calls - # TODO: improved way to check for this. - platform = spack.platforms.real_host().name - if platform == "darwin" or platform == "linux" or platform == "windows": - return - - spec = Spec("externalmodule") - spec.concretize() - assert spec["externalmodule"].external_modules == ["external-module"] - assert "externalprereq" not in spec - assert spec["externalmodule"].compiler.satisfies("gcc") - def test_nobuild_package(self): """Test that a non-buildable package raise an error if no specs in packages.yaml are compatible with the request.