From 3848c41494b683574d9d5cc843769ed53698843c Mon Sep 17 00:00:00 2001 From: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com> Date: Fri, 21 Jun 2024 03:24:46 -0700 Subject: [PATCH] Bugfix: test_is_externally_detectable needs to use mockpackages (#44795) --- lib/spack/spack/test/cmd/info.py | 4 ++-- .../repos/builtin.mock/packages/find-externals1/package.py | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/spack/spack/test/cmd/info.py b/lib/spack/spack/test/cmd/info.py index e3d7b383a5e..a0ea57b03e4 100644 --- a/lib/spack/spack/test/cmd/info.py +++ b/lib/spack/spack/test/cmd/info.py @@ -57,9 +57,9 @@ def test_info_noversion(mock_packages, print_buffer): @pytest.mark.parametrize( - "pkg_query,expected", [("zlib", "False"), ("gcc", "True (version, variants)")] + "pkg_query,expected", [("zlib", "False"), ("find-externals1", "True (version)")] ) -def test_is_externally_detectable(pkg_query, expected, parser, print_buffer): +def test_is_externally_detectable(mock_packages, pkg_query, expected, parser, print_buffer): args = parser.parse_args(["--detectable", pkg_query]) spack.cmd.info.info(parser, args) diff --git a/var/spack/repos/builtin.mock/packages/find-externals1/package.py b/var/spack/repos/builtin.mock/packages/find-externals1/package.py index 2a82fad9b55..07d16a8f221 100644 --- a/var/spack/repos/builtin.mock/packages/find-externals1/package.py +++ b/var/spack/repos/builtin.mock/packages/find-externals1/package.py @@ -16,6 +16,10 @@ class FindExternals1(AutotoolsPackage): version("1.0", md5="abcdef1234567890abcdef1234567890") + @classmethod + def determine_version(cls, exe): + return "1.0" + @classmethod def determine_spec_details(cls, prefix, exes_in_prefix): exe_to_path = dict((os.path.basename(p), p) for p in exes_in_prefix)