zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bugfix: test_is_externally_detectable needs to use mockpackages (#44795)

Browse Source
This commit is contained in:
Tamara Dahlgren 2024-06-21 03:24:46 -07:00 committed by GitHub
parent da720cafd8
commit 3848c41494
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/spack/spack/test/cmd/info.py
View File

@ -57,9 +57,9 @@ def test_info_noversion(mock_packages, print_buffer):
@pytest.mark.parametrize( @pytest.mark.parametrize(
"pkg_query,expected", [("zlib", "False"), ("gcc", "True (version, variants)")] "pkg_query,expected", [("zlib", "False"), ("find-externals1", "True (version)")]
) )
def test_is_externally_detectable(pkg_query, expected, parser, print_buffer): def test_is_externally_detectable(mock_packages, pkg_query, expected, parser, print_buffer):
args = parser.parse_args(["--detectable", pkg_query]) args = parser.parse_args(["--detectable", pkg_query])
spack.cmd.info.info(parser, args) spack.cmd.info.info(parser, args)

4
var/spack/repos/builtin.mock/packages/find-externals1/package.py
View File

@ -16,6 +16,10 @@ class FindExternals1(AutotoolsPackage):
version("1.0", md5="abcdef1234567890abcdef1234567890") version("1.0", md5="abcdef1234567890abcdef1234567890")
@classmethod
def determine_version(cls, exe):
return "1.0"
@classmethod @classmethod
def determine_spec_details(cls, prefix, exes_in_prefix): def determine_spec_details(cls, prefix, exes_in_prefix):
exe_to_path = dict((os.path.basename(p), p) for p in exes_in_prefix) exe_to_path = dict((os.path.basename(p), p) for p in exes_in_prefix)