From 3f5141d629c18ac47562480ef57df42c98297a1a Mon Sep 17 00:00:00 2001 From: Todd Gamblin Date: Fri, 16 Feb 2018 16:59:29 -0800 Subject: [PATCH] refactor: make PackageBase.possible_dependencies() a class method. --- lib/spack/spack/package.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/spack/spack/package.py b/lib/spack/spack/package.py index 4af53e00d0b..d20a6d8e883 100644 --- a/lib/spack/spack/package.py +++ b/lib/spack/spack/package.py @@ -525,9 +525,10 @@ def installed_upstream(self): return self._installed_upstream + @classmethod def possible_dependencies( - self, transitive=True, expand_virtuals=True, visited=None): - """Return set of possible dependencies of this package. + cls, transitive=True, expand_virtuals=True, visited=None): + """Return set of possible transitive dependencies of this package. Note: the set returned *includes* the package itself. @@ -539,9 +540,9 @@ def possible_dependencies( visited (set): set of names of dependencies visited so far. """ if visited is None: - visited = set([self.name]) + visited = set([cls.name]) - for i, name in enumerate(self.dependencies): + for i, name in enumerate(cls.dependencies): if spack.repo.path.is_virtual(name): if expand_virtuals: providers = spack.repo.path.providers_for(name)