Remove recursive symbolic link in lib/spack/docs from git repository (#33483)

Delete code removing the symlink during CI

.github/workflows/unit_tests.yaml

@@ -221,9 +221,6 @@ jobs:
         $(which spack) unit-test --cov --cov-config=pyproject.toml "${common_args[@]}"
         coverage combine -a
         coverage xml
-        # Delete the symlink going from ./lib/spack/docs/_spack_root back to
-        # the initial directory, since it causes ELOOP errors with codecov/actions@2
-        rm lib/spack/docs/_spack_root
     - uses: codecov/codecov-action@d9f34f8cd5cb3b3eb79b3e4b5dae3a16df499a70
       with:
         flags: unittests,macos

.github/workflows/windows_python.yml

@@ -32,7 +32,6 @@ jobs:
         echo F|xcopy .\spack\share\spack\qa\configuration\windows_config.yaml $env:USERPROFILE\.spack\windows\config.yaml
         cd spack
         dir
-        (Get-Item '.\lib\spack\docs\_spack_root').Delete()
         spack unit-test --verbose --cov --cov-config=pyproject.toml --ignore=lib/spack/spack/test/cmd
         coverage combine -a
         coverage xml
@@ -58,7 +57,6 @@ jobs:
       run: |
         echo F|xcopy .\spack\share\spack\qa\configuration\windows_config.yaml $env:USERPROFILE\.spack\windows\config.yaml
         cd spack
-        (Get-Item '.\lib\spack\docs\_spack_root').Delete()
         spack unit-test --verbose --cov --cov-config=pyproject.toml lib/spack/spack/test/cmd
         coverage combine -a
         coverage xml