Overhaul Spack's URL parsing (#2972)

* Remove fake URLs from Spack

* Ignore long lines for URLs that start with ftp:

* Preliminary changes to version regexes

* New redesign of version regexes

* Allow letters in version-only

* Fix detection of versions that end in Final

* Rearrange a few regexes and add examples

* Add tests for common download repositories

* Add test cases for common tarball naming schemes

* Finalize version regexes

* spack url test -> spack url summary

* Clean up comments

* Rearrange suffix checks

* Use query strings for name detection

* Remove no longer necessary url_for_version functions

* Strip off extraneous information after package name

* Add one more test

* Dot in square brackets does not need to be escaped

* Move renaming outside of parse_name_offset

* Fix versions for a couple more packages

* Fix flake8 and doc tests

* Correctly parse Python, Lua, and Bio++ package names

* Use effective URLs for mfem

* Add checksummed version to mitos

* Remove url_for_version from STAR-CCM+ package

* Revert changes to version numbers with underscores and dashes

* Fix name detection for tbb

* Correctly parse Ruby gems

* Reverted mfem back to shortened URLs.

* Updated instructions for better security

* Remove preferred=True from newest version

* Add tests for new `spack url list` flags

* Add tests for strip_name_suffixes

* Add unit tests for version separators

* Fix bugs related to parseable name but in parseable version

* Remove dead code, update docstring

* Ignore 'binary' at end of version string

* Remove platform from version

* Flip libedit version numbers

* Re-support weird NCO alpha/beta versions

* Rebase and remove one new fake URL

* Add / to beginning of regex to avoid picking up similarly named packages

* Ignore weird tar versions

* Fix bug in url parse --spider when no versions found

* Less strict version matching for spack versions

* Don't rename Python packages

* Be a little more selective, version must begin with a digit

* Re-add fake URLs

* Fix up several other packages

* Ignore more file endings

* Add parsing support for Miniconda

* Update tab completion

* XFAILS are now PASSES for 2 web tests

var/spack/repos/builtin/packages/py-rtree/package.py

@@ -28,22 +28,9 @@
 class PyRtree(PythonPackage):
     """Python interface to the RTREE.4 Library."""
     homepage = "http://toblerity.org/rtree/"
-    url      = "https://github.com/Toblerity/rtree/tarball/0.8.2"
+    url      = "https://pypi.io/packages/source/R/Rtree/Rtree-0.8.3.tar.gz"
 
-    # Not an official release yet.  But changes in here are required
-    # to work with Spack.  As it does with all packages, Spack
-    # installs libspatialindex in a non-system location.  Without the
-    # changes in this fork, py-rtree requires an environment variables
-    # to be set *at runtime*, in order to find libspatialindex.  That
-    # is not feasible within the Spack worldview.
-    version('0.8.2.2', 'b1fe96a73153db49ea6ce45a063d82cb',
-        url='https://github.com/citibeth/rtree/tarball/95a678cc7350857a1bb631bc41254efcd1fc0a0d')
-
-    version('0.8.2.1', '394696ca849dd9f3a5ef24fb02a41ef4',
-        url='https://github.com/citibeth/rtree/tarball/3a87d86f66a3955676b2507d3bf424ade938a22b')
-
-    # Does not work with Spack
-    # version('0.8.2', '593c7ac6babc397b8ba58f1636c1e0a0')
+    version('0.8.3', 'a27cb05a85eed0a3605c45ebccc432f8')
 
     depends_on('py-setuptools', type='build')
     depends_on('libspatialindex')