zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

llvm: reformulate a when condition to avoid tautology (#41461)

Browse Source 
The condition on swig can be interpreted as "true if true,
false if false" and gives clingo the option to add swig
or not.

If not other optimization criteria break the tie, then
the concretization is non-deterministic.
This commit is contained in:
Massimiliano Culpo 2023-12-06 19:12:42 +01:00 committed by GitHub
parent b522d8f610
commit 5404a5bb82
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
var/spack/repos/builtin/packages/llvm/package.py
View File

@ -308,14 +308,14 @@ class Llvm(CMakePackage, CudaPackage):
depends_on("swig", when="+python")
depends_on("xz")
# Use ^swig cause it's triggered by both python & lua scripting in lldb
with when("^swig"):
depends_on("swig@2:", when="@10:")
depends_on("swig@3:", when="@12:")
depends_on("swig@4:", when="@17:")
# Commits f0a25fe0b746f56295d5c02116ba28d2f965c175 and
# 81fc5f7909a4ef5a8d4b5da2a10f77f7cb01ba63 fixed swig 4.1 support
depends_on("swig@:4.0", when="@:15")
for _when_spec in ("+lldb+python", "+lldb+lua"):
with when(_when_spec):
depends_on("swig@2:", when="@10:")
depends_on("swig@3:", when="@12:")
depends_on("swig@4:", when="@17:")
# Commits f0a25fe0b746f56295d5c02116ba28d2f965c175 and
# 81fc5f7909a4ef5a8d4b5da2a10f77f7cb01ba63 fixed swig 4.1 support
depends_on("swig@:4.0", when="@:15")
# gold support, required for some features
depends_on("binutils+gold+ld+plugins+headers", when="+gold")