Fix bug in -Xlinker argument handling

- also update test to match.

lib/spack/env/cc

@@ -199,19 +199,20 @@ while [ -n "$1" ]; do
                 other_args+=("-Wl,$arg")
             fi
             ;;
-        -Xlinker,*)
+        -Xlinker)
-            arg="${1#-Xlinker,}"
+            shift; arg="$1";
-            if [ -z "$arg" ]; then shift; arg="$1"; fi
             if [[ $arg = -rpath=* ]]; then
                 rpaths+=("${arg#-rpath=}")
             elif [[ $arg = -rpath ]]; then
                 shift; arg="$1"
-                if [[ $arg != -Xlinker,* ]]; then
+                if [[ $arg != -Xlinker ]]; then
-                    die "-Xlinker,-rpath was not followed by -Xlinker,*"
+                    die "-Xlinker -rpath was not followed by -Xlinker <arg>"
                 fi
-                rpaths+=("${arg#-Xlinker,}")
+                shift; arg="$1"
+                rpaths+=("$arg")
             else
-                other_args+=("-Xlinker,$arg")
+                other_args+=("-Xlinker")
+                other_args+=("$arg")
             fi
             ;;
         *)

lib/spack/spack/test/cc.py

@@ -43,7 +43,7 @@
     '-llib1', '-llib2',
     'arg4',
     '-Wl,--end-group',
-    '-Xlinker,-rpath', '-Xlinker,/third/rpath', '-Xlinker,-rpath', '-Xlinker,/fourth/rpath',
+    '-Xlinker', '-rpath', '-Xlinker', '/third/rpath', '-Xlinker', '-rpath', '-Xlinker', '/fourth/rpath',
     '-llib3', '-llib4',
     'arg5', 'arg6']