gotcha: fixed building v0.0.2 on ARM (#18012)

var/spack/repos/builtin/packages/gotcha/arm.patch

@@ -1,19 +0,0 @@
-commit 6f494384b0f00513d950b94a60c14ad1c20eb353
-Author: David Poliakoff <david.poliakoff@gmail.com>
-Date:   Thu Sep 20 10:59:54 2018 -0700
-
-    Pushed fix to help build on ARM systems
-
-diff --git a/src/libc_wrappers.c b/src/libc_wrappers.c
-index 504e31a..5937e5a 100644
---- a/src/libc_wrappers.c
-+++ b/src/libc_wrappers.c
-@@ -358,7 +358,7 @@ int gotcha_open(const char *pathname, int flags, ...)
-    }
-    va_end(args);
- 
--   result = syscall(SYS_open, pathname, flags, mode);
-+   result = syscall(SYS_openat, AT_FDCWD, pathname, flags, mode);
-    if (result >= 0)
-       return (int) result;
-    

var/spack/repos/builtin/packages/gotcha/package.py

@@ -20,7 +20,10 @@ class Gotcha(CMakePackage):
     version('0.0.2', tag='0.0.2')
 
     variant('test', default=False, description='Build tests for Gotcha')
-    patch('arm.patch', when='@1.0.2')
+    patch(
+        'https://github.com/LLNL/GOTCHA/commit/e82b4a1ecb634075d8f5334b796c888c86da0427.patch', 
+        sha256='9f7814fd3c3362c156bc617c755e7e50c2f9125ed4540e36f60e4d93884f1ce6',
+        when='@0.0.2:1.0.2')
 
     def configure_args(self):
         spec = self.spec