zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve "makefile" build system documentation (#41781)

Browse Source 
Shows how to modify environment variables using
"setup_build_environment" instead of overriding "edit"
This commit is contained in:
Loris Ercole 2024-01-09 16:44:21 +01:00 committed by GitHub
parent 13e8029904
commit 5919bd0799
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/spack/docs/build_systems/makefilepackage.rst
View File

@ -88,13 +88,13 @@ command-line. However, Makefiles that use ``?=`` for assignment honor
environment variables. Since Spack already sets ``CC``, ``CXX``, ``F77``, environment variables. Since Spack already sets ``CC``, ``CXX``, ``F77``,
and ``FC``, you won't need to worry about setting these variables. If and ``FC``, you won't need to worry about setting these variables. If
there are any other variables you need to set, you can do this in the there are any other variables you need to set, you can do this in the
``edit`` method: ``setup_build_environment`` method:
.. code-block:: python .. code-block:: python
def edit(self, spec, prefix): def setup_build_environment(self, env):
env["PREFIX"] = prefix env.set("PREFIX", prefix)
env["BLASLIB"] = spec["blas"].libs.ld_flags env.set("BLASLIB", spec["blas"].libs.ld_flags)
`cbench <https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/cbench/package.py>`_ `cbench <https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/cbench/package.py>`_
@ -140,7 +140,7 @@ Edit Makefile
Some Makefiles are just plain stubborn and will ignore command-line Some Makefiles are just plain stubborn and will ignore command-line
variables. The only way to ensure that these packages build correctly variables. The only way to ensure that these packages build correctly
is to directly edit the Makefile. Spack provides a ``FileFilter`` class is to directly edit the Makefile. Spack provides a ``FileFilter`` class
and a ``filter_file`` method to help with this. For example: and a ``filter`` method to help with this. For example:
.. code-block:: python .. code-block:: python