test_which: do not mutate os.environ

2023-11-22 22:30:49 +01:00 · 2023-11-22 22:30:49 +01:00 · 5b386cf9b1
commit 5b386cf9b1
parent 2cbe84b1ee
1 changed files with 2 additions and 2 deletions
--- a/lib/spack/spack/test/util/executable.py
+++ b/lib/spack/spack/test/util/executable.py
@ -89,8 +89,8 @@ def test_which_with_slash_ignores_path(tmpdir, working_env):
        assert exe.path == path


-def test_which(tmpdir):
-    os.environ["PATH"] = str(tmpdir)
+def test_which(tmpdir, monkeypatch):
+    monkeypatch.setenv("PATH", str(tmpdir))
    assert ex.which("spack-test-exe") is None

    with pytest.raises(ex.CommandNotFoundError):