zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove deprecated "--run-tests" option of "spack install" (#30461)

Browse Source
This commit is contained in:
Massimiliano Culpo 2022-05-04 07:43:29 +02:00 committed by GitHub
parent 96f9a1d88b
commit 5c7d6c6e10
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/spack/spack/cmd/install.py
View File

@ -159,10 +159,6 @@ def setup_parser(subparser):
if 'all' is chosen, run package tests during installation for all if 'all' is chosen, run package tests during installation for all
packages. If neither are chosen, don't run tests for any packages.""" packages. If neither are chosen, don't run tests for any packages."""
) )
testing.add_argument(
'--run-tests', action='store_true',
help='run package tests during installation (same as --test=all)'
)
subparser.add_argument( subparser.add_argument(
'--log-format', '--log-format',
default=None, default=None,
@ -316,11 +312,8 @@ def install(parser, args, **kwargs):
if args.log_file: if args.log_file:
reporter.filename = args.log_file reporter.filename = args.log_file
if args.run_tests:
tty.warn("Deprecated option: --run-tests: use --test=all instead")
def get_tests(specs): def get_tests(specs):
if args.test == 'all' or args.run_tests: if args.test == 'all':
return True return True
elif args.test == 'root': elif args.test == 'root':
return [spec.name for spec in specs] return [spec.name for spec in specs]

1
lib/spack/spack/test/cmd/install.py
View File

@ -87,7 +87,6 @@ def check(pkg):
monkeypatch.setattr(spack.package.PackageBase, 'unit_test_check', check) monkeypatch.setattr(spack.package.PackageBase, 'unit_test_check', check)
install('--test=all', 'a') install('--test=all', 'a')
install('--run-tests', 'a')
def test_install_package_already_installed( def test_install_package_already_installed(

2
share/spack/spack-completion.bash
View File

@ -1170,7 +1170,7 @@ _spack_info() {
_spack_install() { _spack_install() {
if $list_options if $list_options
then then
SPACK_COMPREPLY="-h --help --only -u --until -j --jobs --overwrite --fail-fast --keep-prefix --keep-stage --dont-restage --use-cache --no-cache --cache-only --monitor --monitor-save-local --monitor-tags --monitor-keep-going --monitor-host --monitor-prefix --include-build-deps --no-check-signature --require-full-hash-match --show-log-on-error --source -n --no-checksum --deprecated -v --verbose --fake --only-concrete --no-add -f --file --clean --dirty --test --run-tests --log-format --log-file --help-cdash --cdash-upload-url --cdash-build --cdash-site --cdash-track --cdash-buildstamp -y --yes-to-all -U --fresh --reuse" SPACK_COMPREPLY="-h --help --only -u --until -j --jobs --overwrite --fail-fast --keep-prefix --keep-stage --dont-restage --use-cache --no-cache --cache-only --monitor --monitor-save-local --monitor-tags --monitor-keep-going --monitor-host --monitor-prefix --include-build-deps --no-check-signature --require-full-hash-match --show-log-on-error --source -n --no-checksum --deprecated -v --verbose --fake --only-concrete --no-add -f --file --clean --dirty --test --log-format --log-file --help-cdash --cdash-upload-url --cdash-build --cdash-site --cdash-track --cdash-buildstamp -y --yes-to-all -U --fresh --reuse"
else else
_all_packages _all_packages
fi fi