zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Automatically run LLDB codesign script on mac (#15169)

Browse Source 
Newer versions of LLVM provide a one-line command to set up LLDB code
signing. Now the build will abort only if this command fails.

https://lldb.llvm.org/resources/build.html#code-signing-on-macos
This commit is contained in:
Seth R. Johnson 2020-02-22 14:09:22 -05:00 committed by GitHub
parent 0ea6bab984
commit 629c69d383
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
var/spack/repos/builtin/packages/llvm/package.py
View File

@ -162,11 +162,18 @@ def check_darwin_lldb_codesign_requirement(self):
llvm_check_file) llvm_check_file)
except ProcessError: except ProcessError:
explanation = ('The "lldb_codesign" identity must be available' # Newer LLVM versions have a simple script that sets up
' to build LLVM with LLDB. See https://lldb.llvm' # automatically
'.org/resources/build.html#code-signing-on-macos' setup = Executable("./lldb/scripts/macos-setup-codesign.sh")
'for details on how to create this identity.') try:
raise RuntimeError(explanation) setup()
except Exception:
raise RuntimeError(
'The "lldb_codesign" identity must be available to build '
'LLVM with LLDB. See https://lldb.llvm.org/resources/'
'build.html#code-signing-on-macos for details on how to '
'create this identity.'
)
def setup_build_environment(self, env): def setup_build_environment(self, env):
env.append_flags('CXXFLAGS', self.compiler.cxx11_flag) env.append_flags('CXXFLAGS', self.compiler.cxx11_flag)