arpack-ng: flake8 fixes and minor update of incode comments

This commit is contained in:
Denis Davydov 2016-07-06 13:27:02 +02:00
parent a47b3ba01b
commit 63e45c586c

View File

@ -27,7 +27,8 @@
class ArpackNg(Package):
"""
ARPACK-NG is a collection of Fortran77 subroutines designed to solve large scale eigenvalue problems.
ARPACK-NG is a collection of Fortran77 subroutines designed to solve large
scale eigenvalue problems.
Important Features:
@ -38,16 +39,17 @@ class ArpackNg(Package):
Generalized Problems.
* Routines for Banded Matrices - Standard or Generalized Problems.
* Routines for The Singular Value Decomposition.
* Example driver routines that may be used as templates to implement numerous
Shift-Invert strategies for all problem types, data types and precision.
* Example driver routines that may be used as templates to implement
numerous Shift-Invert strategies for all problem types, data types and
precision.
This project is a joint project between Debian, Octave and Scilab in order to
provide a common and maintained version of arpack.
This project is a joint project between Debian, Octave and Scilab in order
to provide a common and maintained version of arpack.
Indeed, no single release has been published by Rice university for the last
few years and since many software (Octave, Scilab, R, Matlab...) forked it and
implemented their own modifications, arpack-ng aims to tackle this by providing
a common repository and maintained versions.
Indeed, no single release has been published by Rice university for the
last few years and since many software (Octave, Scilab, R, Matlab...)
forked it and implemented their own modifications, arpack-ng aims to tackle
this by providing a common repository and maintained versions.
arpack-ng is replacing arpack almost everywhere.
"""
@ -60,7 +62,8 @@ class ArpackNg(Package):
variant('shared', default=True, description='Enables the build of shared libraries')
variant('mpi', default=False, description='Activates MPI support')
# The function pdlamch10 does not set the return variable. This is fixed upstream
# The function pdlamch10 does not set the return variable.
# This is fixed upstream
# see https://github.com/opencollab/arpack-ng/issues/34
patch('pdlamch10.patch', when='@3.3.0')
@ -82,8 +85,10 @@ def install(self, spec, prefix):
options = ['-DEXAMPLES=ON']
options.extend(std_cmake_args)
# Arpack do directly find_package(BLAS REQUIRED) and
# find_package(LAPACK REQUIRED).
# TODO:
# Arpack calls directly find_package(BLAS REQUIRED) and
# find_package(LAPACK REQUIRED). Make sure correct Blas/Lapack are
# picked up.
if '+mpi' in spec:
options.append('-DMPI=ON')
@ -103,8 +108,6 @@ def install(self, spec, prefix):
@when('@3.3.0')
def install(self, spec, prefix):
# Apparently autotools are not bootstrapped
# TODO: switch to use the CMake build in the next version
# rather than bootstrapping.
which('libtoolize')()
bootstrap = Executable('./bootstrap')