zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

arpack-ng: flake8 fixes and minor update of incode comments

Browse Source
This commit is contained in:
Denis Davydov 2016-07-06 13:27:02 +02:00
parent a47b3ba01b
commit 63e45c586c
1 changed files with 17 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
var/spack/repos/builtin/packages/arpack-ng/package.py
View File

@ -27,7 +27,8 @@
class ArpackNg(Package): class ArpackNg(Package):
""" """
ARPACK-NG is a collection of Fortran77 subroutines designed to solve large scale eigenvalue problems. ARPACK-NG is a collection of Fortran77 subroutines designed to solve large
scale eigenvalue problems.
Important Features: Important Features:
@ -38,16 +39,17 @@ class ArpackNg(Package):
Generalized Problems. Generalized Problems.
* Routines for Banded Matrices - Standard or Generalized Problems. * Routines for Banded Matrices - Standard or Generalized Problems.
* Routines for The Singular Value Decomposition. * Routines for The Singular Value Decomposition.
* Example driver routines that may be used as templates to implement numerous * Example driver routines that may be used as templates to implement
Shift-Invert strategies for all problem types, data types and precision. numerous Shift-Invert strategies for all problem types, data types and
precision.
This project is a joint project between Debian, Octave and Scilab in order to This project is a joint project between Debian, Octave and Scilab in order
provide a common and maintained version of arpack. to provide a common and maintained version of arpack.
Indeed, no single release has been published by Rice university for the last Indeed, no single release has been published by Rice university for the
few years and since many software (Octave, Scilab, R, Matlab...) forked it and last few years and since many software (Octave, Scilab, R, Matlab...)
implemented their own modifications, arpack-ng aims to tackle this by providing forked it and implemented their own modifications, arpack-ng aims to tackle
a common repository and maintained versions. this by providing a common repository and maintained versions.
arpack-ng is replacing arpack almost everywhere. arpack-ng is replacing arpack almost everywhere.
""" """
@ -60,7 +62,8 @@ class ArpackNg(Package):
variant('shared', default=True, description='Enables the build of shared libraries') variant('shared', default=True, description='Enables the build of shared libraries')
variant('mpi', default=False, description='Activates MPI support') variant('mpi', default=False, description='Activates MPI support')
# The function pdlamch10 does not set the return variable. This is fixed upstream # The function pdlamch10 does not set the return variable.
# This is fixed upstream
# see https://github.com/opencollab/arpack-ng/issues/34 # see https://github.com/opencollab/arpack-ng/issues/34
patch('pdlamch10.patch', when='@3.3.0') patch('pdlamch10.patch', when='@3.3.0')
@ -82,8 +85,10 @@ def install(self, spec, prefix):
options = ['-DEXAMPLES=ON'] options = ['-DEXAMPLES=ON']
options.extend(std_cmake_args) options.extend(std_cmake_args)
# Arpack do directly find_package(BLAS REQUIRED) and # TODO:
# find_package(LAPACK REQUIRED). # Arpack calls directly find_package(BLAS REQUIRED) and
# find_package(LAPACK REQUIRED). Make sure correct Blas/Lapack are
# picked up.
if '+mpi' in spec: if '+mpi' in spec:
options.append('-DMPI=ON') options.append('-DMPI=ON')
@ -103,8 +108,6 @@ def install(self, spec, prefix):
@when('@3.3.0') @when('@3.3.0')
def install(self, spec, prefix): def install(self, spec, prefix):
# Apparently autotools are not bootstrapped # Apparently autotools are not bootstrapped
# TODO: switch to use the CMake build in the next version
# rather than bootstrapping.
which('libtoolize')() which('libtoolize')()
bootstrap = Executable('./bootstrap') bootstrap = Executable('./bootstrap')