zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

modules : iterating on all the dependencies doesn't reuire try/except KeyError

Browse Source
This commit is contained in:
alalazo 2016-04-05 18:44:40 +02:00
parent 5da37c573f
commit 670cb423f9
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/spack/spack/modules.py
View File

@ -182,7 +182,6 @@ def dependencies(request='All'):
# TODO : the code down below is quite similar to build_environment.setup_package and needs to be # TODO : the code down below is quite similar to build_environment.setup_package and needs to be
# TODO : factored out to a single place # TODO : factored out to a single place
for item in dependencies('All'): for item in dependencies('All'):
try:
package = self.spec[item.name].package package = self.spec[item.name].package
modules = parent_class_modules(package.__class__) modules = parent_class_modules(package.__class__)
for mod in modules: for mod in modules:
@ -190,10 +189,6 @@ def dependencies(request='All'):
set_module_variables_for_package(package, package.module) set_module_variables_for_package(package, package.module)
package.setup_dependent_package(self.pkg.module, self.spec) package.setup_dependent_package(self.pkg.module, self.spec)
package.setup_dependent_environment(spack_env, env, self.spec) package.setup_dependent_environment(spack_env, env, self.spec)
except KeyError as e:
# The extends was conditional, so it doesn't count here
# eg: extends('python', when='+python')
tty.debug(str(e))
# Package-specific environment modifications # Package-specific environment modifications
set_module_variables_for_package(self.pkg, self.pkg.module) set_module_variables_for_package(self.pkg, self.pkg.module)