zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert addition of SPACK_EDITOR pending review.

Browse Source 
This reverts commit d8a26905ee.
This reverts commit 1ee049ccc3.

These were spuriously pushed to `develop`.
This commit is contained in:
Todd Gamblin
2023-04-18 03:57:24 -07:00
parent 1ee049ccc3
commit 6845f41d67
5 changed files with 61 additions and 159 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/spack/docs/getting_started.rst
View File

@@ -368,8 +368,7 @@ Manual compiler configuration
If auto-detection fails, you can manually configure a compiler by
editing your ``~/.spack/<platform>/compilers.yaml`` file. You can do this by running
``spack config edit compilers``, which will open the file in
:ref:`your favorite editor <controlling-the-editor>`.
``spack config edit compilers``, which will open the file in your ``$EDITOR``.
Each compiler configuration in the file looks like this:

30
lib/spack/docs/packaging_guide.rst
View File

@@ -229,8 +229,7 @@ always choose to download just one tarball initially, and run
Spack automatically creates a directory in the appropriate repository,
generates a boilerplate template for your package, and opens up the new
``package.py`` in your favorite ``$EDITOR`` (see :ref:`controlling-the-editor`
for details):
``package.py`` in your favorite ``$EDITOR``:
.. code-block:: python
:linenos:
@@ -336,31 +335,6 @@ The rest of the tasks you need to do are as follows:
:ref:`installation_process` is
covered in detail later.
.. _controlling-the-editor:
^^^^^^^^^^^^^^^^^^^^^^^^^
Controlling the editor
^^^^^^^^^^^^^^^^^^^^^^^^^
When Spack needs to open an editor for you (e.g., for commands like
:ref:`cmd-spack-create` or :ref:`spack edit`, it looks at several environment variables
to figure out what to use. The order of precedence is:
* ``SPACK_EDITOR``: highest precedence, in case you want something specific for Spack;
* ``VISUAL``: standard environment variable for full-screen editors like ``vim`` or ``emacs``;
* ``EDITOR``: older environment variable for your editor.
You can set any of these to the command you want to run, e.g., in ``bash`` you might run
one of these::
export VISUAL=vim
export EDITOR="emacs -nw"
export SPACK_EDITOR=nano
If Spack finds none of these variables set, it will look for ``vim``, ``vi``, ``emacs``,
``nano``, and ``notepad``, in that order.
^^^^^^^^^^^^^^^^^^^^^^^^^
Non-downloadable software
^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -1813,7 +1787,7 @@ for instructions on setting up a mirror.
After running ``spack install pgi``, the first thing that will happen is
Spack will create a global license file located at
``$SPACK_ROOT/etc/spack/licenses/pgi/license.dat``. It will then open up the
file using :ref:`your favorite editor <controlling-the-editor>`. It will look like
file using the editor set in ``$EDITOR``, or vi if unset. It will look like
this:
.. code-block:: sh