gitlab: Remove temporary storage url from all stacks (#29949)

Gitlab pipelines run for spack already have other S3 storage locations
configured for storage of binaries, so this PR removes the redundant
per-pipeline mirror.  As a result, the "cleanup" jobs will no longer be
generated at the end of each pipeline, removing one possible point of
pipeline failure.

share/spack/gitlab/cloud_pipelines/stacks/build_systems/spack.yaml

@@ -96,7 +96,6 @@ spack:
             CI_JOB_SIZE: "default"
 
 
-    temporary-storage-url-prefix: "s3://spack-binaries-prs/pipeline-storage"
     broken-specs-url: "s3://spack-binaries-develop/broken-specs"
     service-job-attributes:
       before_script:

share/spack/gitlab/cloud_pipelines/stacks/data-vis-sdk/spack.yaml

@@ -134,15 +134,12 @@ spack:
             KUBERNETES_CPU_REQUEST: "500m"
             KUBERNETES_MEMORY_REQUEST: "500M"
 
-
       - match: ['@:']
         runner-attributes:
           tags: ["spack", "public", "x86_64"]
           variables:
             CI_JOB_SIZE: "default"
 
-
-    temporary-storage-url-prefix: "s3://spack-binaries-prs/pipeline-storage"
     broken-specs-url: "s3://spack-binaries-develop/broken-specs"
     service-job-attributes:
       image: { "name": "ghcr.io/spack/e4s-ubuntu-18.04:v2021-10-18", "entrypoint": [""] }

share/spack/gitlab/cloud_pipelines/stacks/e4s-mac/spack.yaml

@@ -47,7 +47,6 @@ spack:
         runner-attributes:
           tags:
           - omicron
-    temporary-storage-url-prefix: "s3://spack-binaries-prs/pipeline-storage"
     broken-specs-url: "s3://spack-binaries-develop/broken-specs"
     service-job-attributes:
       before_script:

share/spack/gitlab/cloud_pipelines/stacks/e4s-on-power/spack.yaml

@@ -241,7 +241,6 @@ spack:
         runner-attributes:
           image: { "name": "ghcr.io/spack/e4s-ubuntu-20.04:v2021-10-18", "entrypoint": [""] }
           tags: ["spack", "public", "large", "ppc64le"]
-    temporary-storage-url-prefix: "s3://spack-binaries-prs/pipeline-storage"
     broken-specs-url: "s3://spack-binaries-develop/broken-specs"
     service-job-attributes:
       before_script:

share/spack/gitlab/cloud_pipelines/stacks/e4s/spack.yaml

@@ -403,7 +403,6 @@ spack:
           variables:
             CI_JOB_SIZE: "default"
 
-    temporary-storage-url-prefix: "s3://spack-binaries-prs/pipeline-storage"
     broken-specs-url: "s3://spack-binaries-develop/broken-specs"
     service-job-attributes:
       before_script:

share/spack/gitlab/cloud_pipelines/stacks/radiuss/spack.yaml

@@ -158,7 +158,7 @@ spack:
           tags: ["spack", "public", "x86_64"]
           variables:
             CI_JOB_SIZE: "default"
-    temporary-storage-url-prefix: "s3://spack-binaries-prs/pipeline-storage"
+
     service-job-attributes:
       before_script:
         - . "./share/spack/setup-env.sh"

share/spack/gitlab/cloud_pipelines/stacks/tutorial/spack.yaml

@@ -134,7 +134,7 @@ spack:
           tags: ["spack", "public", "x86_64"]
           variables:
             CI_JOB_SIZE: default
-    temporary-storage-url-prefix: "s3://spack-binaries-prs/pipeline-storage"
+
     broken-specs-url: "s3://spack-binaries-develop/broken-specs"
     service-job-attributes:
       image: { "name": "ghcr.io/spack/tutorial-ubuntu-18.04:v2021-11-02", "entrypoint": [""] }
@@ -143,7 +143,6 @@ spack:
         - spack --version
       tags: ["spack", "public", "x86_64"]
 
-
   cdash:
     build-group: Spack Tutorial
     url: https://cdash.spack.io