zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

High performance linkers for LBANN (#23594)

Browse Source 
* Added the option to use high performance linkers: gold and lld, for
LBANN.  Including them as build flags causes unnecessary propagation
to all dependent packages, reducing package reuse.
This commit is contained in:
Brian Van Essen 2021-05-12 12:18:01 -07:00 committed by GitHub
parent 3c05130258
commit 6b7c57ad47
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
var/spack/repos/builtin/packages/lbann/package.py
View File

@ -69,6 +69,14 @@ class Lbann(CMakePackage, CudaPackage, ROCmPackage):
variant('pfe', default=True, description='Python Frontend for generating and launching models') variant('pfe', default=True, description='Python Frontend for generating and launching models')
variant('boost', default=False, description='Enable callbacks that use Boost libraries') variant('boost', default=False, description='Enable callbacks that use Boost libraries')
# LBANN benefits from high performance linkers, but passing these in as command
# line options forces the linker flags to unnecessarily propagate to all
# dependent packages. Don't include gold or lld as dependencies
variant('gold', default=False, description='Use gold high performance linker')
variant("lld", default=False, description="Use lld high performance linker")
# Don't expose this a dependency until Spack can find the external properly
# depends_on('binutils+gold', type='build', when='+gold')
# Variant Conflicts # Variant Conflicts
conflicts('@:0.90,0.99:', when='~conduit') conflicts('@:0.90,0.99:', when='~conduit')
conflicts('@0.90:0.101.99', when='+fft') conflicts('@0.90:0.101.99', when='+fft')
@ -84,6 +92,14 @@ class Lbann(CMakePackage, CudaPackage, ROCmPackage):
conflicts('~python', when='@0.91:0.101') conflicts('~python', when='@0.91:0.101')
conflicts('~pfe', when='@0.91:0.101') conflicts('~pfe', when='@0.91:0.101')
for comp in spack.compilers.supported_compilers():
if comp != 'clang':
conflicts('+lld', when='%' + comp)
conflicts("+lld", when="+gold")
conflicts('+gold', when='platform=darwin', msg="gold does not work on Darwin")
conflicts('+lld', when='platform=darwin', msg="lld does not work on Darwin")
depends_on('cmake@3.17.0:', type='build') depends_on('cmake@3.17.0:', type='build')
# Specify the correct versions of Hydrogen # Specify the correct versions of Hydrogen
@ -237,6 +253,18 @@ def common_config_args(self):
'-DCNPY_DIR={0}'.format(spec['cnpy'].prefix), '-DCNPY_DIR={0}'.format(spec['cnpy'].prefix),
) )
# Use lld high performance linker
if '+lld' in spec:
args.extend([
'-DCMAKE_EXE_LINKER_FLAGS=-fuse-ld=lld',
'-DCMAKE_SHARED_LINKER_FLAGS=-fuse-ld=lld'])
# Use gold high performance linker
if '+gold' in spec:
args.extend([
'-DCMAKE_EXE_LINKER_FLAGS=-fuse-ld=gold',
'-DCMAKE_SHARED_LINKER_FLAGS=-fuse-ld=gold'])
return args return args
def setup_build_environment(self, env): def setup_build_environment(self, env):