zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Resolve unzip build failure with %oneapi (#42593)

Browse Source 
* apply patch to all compilers as per spack/issues/42007

* [@spackbot] updating style on behalf of Chrismarsh

* Resolve flake8 style issue from spackbot

* fix flake8 trailing whitespace

---------

Co-authored-by: Chrismarsh <Chrismarsh@users.noreply.github.com>
This commit is contained in:
Chris Marsh 2024-02-09 14:04:05 -06:00 committed by GitHub
parent 4f0a8fce52
commit 6dd19594ab
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
var/spack/repos/builtin/packages/unzip/package.py
View File

@ -16,7 +16,9 @@ class Unzip(MakefilePackage):
version("6.0", sha256="036d96991646d0449ed0aa952e4fbe21b476ce994abc276e49d30e686708bd37") version("6.0", sha256="036d96991646d0449ed0aa952e4fbe21b476ce994abc276e49d30e686708bd37")
patch("configure-cflags.patch", when="%clang@16:") # clang and oneapi need this patch, likely others
# There is no problem with it on gcc, so make it a catch all
patch("configure-cflags.patch")
# The Cray cc wrapper doesn't handle the '-s' flag (strip) cleanly. # The Cray cc wrapper doesn't handle the '-s' flag (strip) cleanly.
@when("platform=cray") @when("platform=cray")
@ -27,9 +29,8 @@ def get_make_args(self):
make_args = ["-f", join_path("unix", "Makefile")] make_args = ["-f", join_path("unix", "Makefile")]
cflags = [] cflags = []
if self.spec.satisfies("%clang@16:"): cflags.append("-Wno-error=implicit-function-declaration")
cflags.append("-Wno-error=implicit-function-declaration") cflags.append("-Wno-error=implicit-int")
cflags.append("-Wno-error=implicit-int")
cflags.append("-DLARGE_FILE_SUPPORT") cflags.append("-DLARGE_FILE_SUPPORT")
make_args.append('LOC="{}"'.format(" ".join(cflags))) make_args.append('LOC="{}"'.format(" ".join(cflags)))