zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Intel MKL express requirements as requires (#44727)

Browse Source 
The ``+cluster` variant requires there be an MPI family known in the
spec. When using externals it is easy to miss-configure this requirement
leading to a runtime exception which is not desirable. This converts the
exception to a package rule.
This commit is contained in:
kwryankrattiger 2024-06-14 18:07:37 -05:00 committed by GitHub
parent e092026eb8
commit 72bb656b9e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
var/spack/repos/builtin/packages/intel-oneapi-mkl/package.py
View File

@ -148,6 +148,18 @@ class IntelOneapiMkl(IntelOneApiLibraryPackage):
# cluster libraries need mpi # cluster libraries need mpi
depends_on("mpi", when="+cluster") depends_on("mpi", when="+cluster")
# If a +cluster then mpi_family must be set
with when("+cluster"):
conflicts("mpi_family=none")
requires("mpi_family=mpich", when="^intel-oneapi-mpi")
requires("mpi_family=mpich", when="^intel-mpi")
requires("mpi_family=mpich", when="^mpich")
requires("mpi_family=mpich", when="^mvapich")
requires("mpi_family=mpich", when="^mvapich2")
requires("mpi_family=mpich", when="^cray-mpich")
requires("mpi_family=openmpi", when="^openmpi")
requires("mpi_family=openmpi", when="^hpcx-mpi")
provides("fftw-api@3") provides("fftw-api@3")
provides("scalapack", when="+cluster") provides("scalapack", when="+cluster")
provides("mkl") provides("mkl")
@ -226,31 +238,10 @@ def _find_mkl_libs(self, shared):
libs.append("libmkl_core") libs.append("libmkl_core")
if self.spec.satisfies("+cluster"): if self.spec.satisfies("+cluster"):
if any( if self.spec.satisfies("mpi_family=mpich"):
self.spec.satisfies(m)
for m in [
"^intel-oneapi-mpi",
"^intel-mpi",
"^mpich",
"^mvapich",
"^mvapich2",
"^cray-mpich",
"mpi_family=mpich",
]
):
libs.append(self._xlp64_lib("libmkl_blacs_intelmpi")) libs.append(self._xlp64_lib("libmkl_blacs_intelmpi"))
elif any( elif self.spec.satisfies("mpi_family=openmpi"):
self.spec.satisfies(m) for m in ["^openmpi", "^hpcx-mpi", "mpi_family=openmpi"]
):
libs.append(self._xlp64_lib("libmkl_blacs_openmpi")) libs.append(self._xlp64_lib("libmkl_blacs_openmpi"))
else:
raise RuntimeError(
(
"intel-oneapi-mkl +cluster requires one of ^intel-oneapi-mpi, "
"^intel-mpi, ^mpich, ^cray-mpich, mpi_family=mpich, ^openmpi, "
"^hpcx-mpi, or mpi_family=openmpi"
)
)
lib_path = ( lib_path = (
self.component_prefix.lib if self.v2_layout else self.component_prefix.lib.intel64 self.component_prefix.lib if self.v2_layout else self.component_prefix.lib.intel64