Rework libgd package (#1679)

* Added missing libtiff dependency
* added dependency on fontconfig
* Added version 2.2.3
* use autotools rather than cmake

The cmake build was not producing a complete install.
* There was no versioning of the installed libraries.
* gdlib-config was missing
* pkgconfig directory was missing

These problems do not happen when built with autotools.

var/spack/repos/builtin/packages/libgd/package.py

@@ -40,18 +40,33 @@ class Libgd(Package):
     homepage = "https://github.com/libgd/libgd"
     url      = "https://github.com/libgd/libgd/archive/gd-2.1.1.tar.gz"
 
+    version('2.2.3', 'a67bd15fa33d4aac0a1c7904aed19f49')
     version('2.1.1', 'e91a1a99903e460e7ba00a794e72cc1e')
 
+    # Build dependencies
+    depends_on('autoconf', type='build')
+    depends_on('automake', type='build')
+    depends_on('libtool', type='build')
+    depends_on('m4', type='build')
+    depends_on('gettext', type='build')
+    depends_on('pkg-config', type='build')
+
     depends_on('libpng')
-    depends_on('cmake', type='build')
+    depends_on('libtiff')
+    depends_on('fontconfig')
 
     def install(self, spec, prefix):
-
+        autoreconf("--install", "--force",
-        with working_dir('spack-build', create=True):
+                   "-I", "m4",
-            cmake('..',
+                   "-I", join_path(spec['gettext'].prefix,
-                  '-DENABLE_JPEG:BOOL=ON',
+                                   "share", "aclocal"),
-                  '-DENABLE_PNG:BOOL=ON',
+                   "-I", join_path(spec['pkg-config'].prefix,
-                  '-DENABLE_TIFF:BOOL=ON',
+                                   "share", "aclocal"),
-                  *std_cmake_args)
+                   "-I", join_path(spec['automake'].prefix,
-            make()
+                                   "share", "aclocal"),
-            make("install")
+                   "-I", join_path(spec['libtool'].prefix,
+                                   "share", "aclocal")
+                   )
+        configure('--prefix={0}'.format(prefix))
+        make()
+        make("install")